Skip to content

Commit 47b564b

Browse files
committed
login: If web-auth error is PlatformException, show error.message to user
Fixes: #609
1 parent 76ba652 commit 47b564b

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

lib/widgets/login.dart

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -301,10 +301,14 @@ class _LoginPageState extends State<LoginPage> {
301301
assert(debugLog(e.toString()));
302302
if (!mounted) return;
303303
final zulipLocalizations = ZulipLocalizations.of(context);
304-
// Could show different error messages for different failure modes.
304+
305+
String message = zulipLocalizations.errorWebAuthOperationalError;
306+
if (e is PlatformException && e.message != null) {
307+
message = e.message!;
308+
}
305309
await showErrorDialog(context: context,
306310
title: zulipLocalizations.errorWebAuthOperationalErrorTitle,
307-
message: zulipLocalizations.errorWebAuthOperationalError);
311+
message: message);
308312
} finally {
309313
setState(() {
310314
_inProgress = false;
@@ -341,10 +345,14 @@ class _LoginPageState extends State<LoginPage> {
341345

342346
if (!mounted) return;
343347
final zulipLocalizations = ZulipLocalizations.of(context);
344-
// Could show different error messages for different failure modes.
348+
349+
String message = zulipLocalizations.errorWebAuthOperationalError;
350+
if (e is PlatformException && e.message != null) {
351+
message = e.message!;
352+
}
345353
await showErrorDialog(context: context,
346354
title: zulipLocalizations.errorWebAuthOperationalErrorTitle,
347-
message: zulipLocalizations.errorWebAuthOperationalError);
355+
message: message);
348356
}
349357
}
350358

0 commit comments

Comments
 (0)