Skip to content

Commit 40f93af

Browse files
chrisbobbegnprice
authored andcommitted
content test [nfc]: s/prepareContent/prepare/
1 parent 9a25819 commit 40f93af

File tree

1 file changed

+31
-31
lines changed

1 file changed

+31
-31
lines changed

test/widgets/content_test.dart

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ void main() {
180180
testContentSmoke(ContentExample.spoilerRichHeaderAndContent);
181181

182182
group('interactions: spoiler with tappable content (an image) in the header', () {
183-
Future<List<Route<dynamic>>> prepareContent(WidgetTester tester, String html) async {
183+
Future<List<Route<dynamic>>> prepare(WidgetTester tester, String html) async {
184184
final pushedRoutes = <Route<dynamic>>[];
185185
final testNavObserver = TestNavigatorObserver()
186186
..onPushed = (route, prevRoute) => pushedRoutes.add(route);
@@ -213,15 +213,15 @@ void main() {
213213
const example = ContentExample.spoilerHeaderHasImage;
214214

215215
testWidgets('tap image', (tester) async {
216-
final pushedRoutes = await prepareContent(tester, example.html);
216+
final pushedRoutes = await prepare(tester, example.html);
217217

218218
await tester.tap(find.byType(RealmContentNetworkImage));
219219
check(pushedRoutes).single.isA<AccountPageRouteBuilder>()
220220
.fullscreenDialog.isTrue(); // recognize the lightbox
221221
});
222222

223223
testWidgets('tap header on expand/collapse icon', (tester) async {
224-
final pushedRoutes = await prepareContent(tester, example.html);
224+
final pushedRoutes = await prepare(tester, example.html);
225225
checkIsExpanded(tester, false);
226226

227227
await tester.tap(find.byIcon(Icons.expand_more));
@@ -236,7 +236,7 @@ void main() {
236236
});
237237

238238
testWidgets('tap header away from expand/collapse icon (and image)', (tester) async {
239-
final pushedRoutes = await prepareContent(tester, example.html);
239+
final pushedRoutes = await prepare(tester, example.html);
240240
checkIsExpanded(tester, false);
241241

242242
await tester.tapAt(
@@ -257,7 +257,7 @@ void main() {
257257
testContentSmoke(ContentExample.quotation);
258258

259259
group('MessageImage, MessageImageList', () {
260-
Future<void> prepareContent(WidgetTester tester, String html) async {
260+
Future<void> prepare(WidgetTester tester, String html) async {
261261
await prepareContentBare(tester,
262262
// Message is needed for an image's lightbox.
263263
messageContent(html),
@@ -268,7 +268,7 @@ void main() {
268268

269269
testWidgets('single image', (tester) async {
270270
const example = ContentExample.imageSingle;
271-
await prepareContent(tester, example.html);
271+
await prepare(tester, example.html);
272272
final expectedImages = (example.expectedNodes[0] as ImageNodeList).images;
273273
final images = tester.widgetList<RealmContentNetworkImage>(
274274
find.byType(RealmContentNetworkImage));
@@ -278,7 +278,7 @@ void main() {
278278

279279
testWidgets('image with invalid src URL', (tester) async {
280280
const example = ContentExample.imageInvalidUrl;
281-
await prepareContent(tester, example.html);
281+
await prepare(tester, example.html);
282282
// The image indeed has an invalid URL.
283283
final expectedImages = (example.expectedNodes[0] as ImageNodeList).images;
284284
check(() => Uri.parse(expectedImages.single.srcUrl)).throws();
@@ -290,7 +290,7 @@ void main() {
290290

291291
testWidgets('multiple images', (tester) async {
292292
const example = ContentExample.imageCluster;
293-
await prepareContent(tester, example.html);
293+
await prepare(tester, example.html);
294294
final expectedImages = (example.expectedNodes[1] as ImageNodeList).images;
295295
final images = tester.widgetList<RealmContentNetworkImage>(
296296
find.byType(RealmContentNetworkImage));
@@ -300,7 +300,7 @@ void main() {
300300

301301
testWidgets('content after image cluster', (tester) async {
302302
const example = ContentExample.imageClusterThenContent;
303-
await prepareContent(tester, example.html);
303+
await prepare(tester, example.html);
304304
final expectedImages = (example.expectedNodes[1] as ImageNodeList).images;
305305
final images = tester.widgetList<RealmContentNetworkImage>(
306306
find.byType(RealmContentNetworkImage));
@@ -310,7 +310,7 @@ void main() {
310310

311311
testWidgets('multiple clusters of images', (tester) async {
312312
const example = ContentExample.imageMultipleClusters;
313-
await prepareContent(tester, example.html);
313+
await prepare(tester, example.html);
314314
final expectedImages = (example.expectedNodes[1] as ImageNodeList).images
315315
+ (example.expectedNodes[4] as ImageNodeList).images;
316316
final images = tester.widgetList<RealmContentNetworkImage>(
@@ -321,7 +321,7 @@ void main() {
321321

322322
testWidgets('image as immediate child in implicit paragraph', (tester) async {
323323
const example = ContentExample.imageInImplicitParagraph;
324-
await prepareContent(tester, example.html);
324+
await prepare(tester, example.html);
325325
final expectedImages = ((example.expectedNodes[0] as ListNode)
326326
.items[0][0] as ImageNodeList).images;
327327
final images = tester.widgetList<RealmContentNetworkImage>(
@@ -332,7 +332,7 @@ void main() {
332332

333333
testWidgets('image cluster in implicit paragraph', (tester) async {
334334
const example = ContentExample.imageClusterInImplicitParagraph;
335-
await prepareContent(tester, example.html);
335+
await prepare(tester, example.html);
336336
final expectedImages = ((example.expectedNodes[0] as ListNode)
337337
.items[0][1] as ImageNodeList).images;
338338
final images = tester.widgetList<RealmContentNetworkImage>(
@@ -343,7 +343,7 @@ void main() {
343343
});
344344

345345
group("MessageInlineVideo", () {
346-
Future<List<Route<dynamic>>> prepareContent(WidgetTester tester, String html) async {
346+
Future<List<Route<dynamic>>> prepare(WidgetTester tester, String html) async {
347347
final pushedRoutes = <Route<dynamic>>[];
348348
final testNavObserver = TestNavigatorObserver()
349349
..onPushed = (route, prevRoute) => pushedRoutes.add(route);
@@ -366,7 +366,7 @@ void main() {
366366

367367
testWidgets('tapping on preview opens lightbox', (tester) async {
368368
const example = ContentExample.videoInline;
369-
final pushedRoutes = await prepareContent(tester, example.html);
369+
final pushedRoutes = await prepare(tester, example.html);
370370

371371
await tester.tap(find.byIcon(Icons.play_arrow_rounded));
372372
check(pushedRoutes).single.isA<AccountPageRouteBuilder>()
@@ -375,7 +375,7 @@ void main() {
375375
});
376376

377377
group("MessageEmbedVideo", () {
378-
Future<void> prepareContent(WidgetTester tester, String html) async {
378+
Future<void> prepare(WidgetTester tester, String html) async {
379379
await prepareContentBare(tester,
380380
// Message is needed for a video's lightbox.
381381
messageContent(html),
@@ -384,7 +384,7 @@ void main() {
384384
}
385385

386386
Future<void> checkEmbedVideo(WidgetTester tester, ContentExample example) async {
387-
await prepareContent(tester, example.html);
387+
await prepare(tester, example.html);
388388

389389
final expectedTitle = (((example.expectedNodes[0] as ParagraphNode)
390390
.nodes.single as LinkNode).nodes.single as TextNode).text;
@@ -519,14 +519,14 @@ void main() {
519519
// https://github.com/flutter/flutter/wiki/Flutter-Test-Fonts
520520
// We use this to simulate taps on specific glyphs.
521521

522-
Future<void> prepareContent(WidgetTester tester, String html) async {
522+
Future<void> prepare(WidgetTester tester, String html) async {
523523
await prepareContentBare(tester, plainContent(html),
524524
// We try to resolve relative links on the self-account's realm.
525525
wrapWithPerAccountStoreWidget: true);
526526
}
527527

528528
testWidgets('can tap a link to open URL', (tester) async {
529-
await prepareContent(tester,
529+
await prepare(tester,
530530
'<p><a href="https://example/">hello</a></p>');
531531

532532
await tapText(tester, find.text('hello'));
@@ -540,7 +540,7 @@ void main() {
540540
testWidgets('multiple links in paragraph', (tester) async {
541541
final fontSize = Paragraph.textStyle.fontSize!;
542542

543-
await prepareContent(tester,
543+
await prepare(tester,
544544
'<p><a href="https://a/">foo</a> bar <a href="https://b/">baz</a></p>');
545545
final base = tester.getTopLeft(find.text('foo bar baz'))
546546
.translate(fontSize/2, fontSize/2); // middle of first letter
@@ -558,7 +558,7 @@ void main() {
558558
});
559559

560560
testWidgets('link nested in other spans', (tester) async {
561-
await prepareContent(tester,
561+
await prepare(tester,
562562
'<p><strong><em><a href="https://a/">word</a></em></strong></p>');
563563
await tapText(tester, find.text('word'));
564564
check(testBinding.takeLaunchUrlCalls())
@@ -568,7 +568,7 @@ void main() {
568568
testWidgets('link containing other spans', (tester) async {
569569
final fontSize = Paragraph.textStyle.fontSize!;
570570

571-
await prepareContent(tester,
571+
await prepare(tester,
572572
'<p><a href="https://a/">two <strong><em><code>words</code></em></strong></a></p>');
573573
final base = tester.getTopLeft(find.text('two words'))
574574
.translate(fontSize/2, fontSize/2); // middle of first letter
@@ -583,23 +583,23 @@ void main() {
583583
});
584584

585585
testWidgets('relative links are resolved', (tester) async {
586-
await prepareContent(tester,
586+
await prepare(tester,
587587
'<p><a href="/a/b?c#d">word</a></p>');
588588
await tapText(tester, find.text('word'));
589589
check(testBinding.takeLaunchUrlCalls())
590590
.single.equals((url: Uri.parse('${eg.realmUrl}a/b?c#d'), mode: LaunchMode.platformDefault));
591591
});
592592

593593
testWidgets('link inside HeadingNode', (tester) async {
594-
await prepareContent(tester,
594+
await prepare(tester,
595595
'<h6><a href="https://a/">word</a></h6>');
596596
await tapText(tester, find.text('word'));
597597
check(testBinding.takeLaunchUrlCalls())
598598
.single.equals((url: Uri.parse('https://a/'), mode: LaunchMode.platformDefault));
599599
});
600600

601601
testWidgets('error dialog if invalid link', (tester) async {
602-
await prepareContent(tester,
602+
await prepare(tester,
603603
'<p><a href="file:///etc/bad">word</a></p>');
604604
testBinding.launchUrlResult = false;
605605
await tapText(tester, find.text('word'));
@@ -611,7 +611,7 @@ void main() {
611611
});
612612

613613
group('LinkNode on internal links', () {
614-
Future<List<Route<dynamic>>> prepareContent(WidgetTester tester, String html) async {
614+
Future<List<Route<dynamic>>> prepare(WidgetTester tester, String html) async {
615615
final pushedRoutes = <Route<dynamic>>[];
616616
final testNavObserver = TestNavigatorObserver()
617617
..onPushed = (route, prevRoute) => pushedRoutes.add(route);
@@ -632,7 +632,7 @@ void main() {
632632
}
633633

634634
testWidgets('valid internal links are navigated to within app', (tester) async {
635-
final pushedRoutes = await prepareContent(tester,
635+
final pushedRoutes = await prepare(tester,
636636
'<p><a href="/#narrow/stream/1-check">stream</a></p>');
637637

638638
await tapText(tester, find.text('stream'));
@@ -643,7 +643,7 @@ void main() {
643643

644644
testWidgets('invalid internal links are opened in browser', (tester) async {
645645
// Link is invalid due to `topic` operator missing an operand.
646-
final pushedRoutes = await prepareContent(tester,
646+
final pushedRoutes = await prepare(tester,
647647
'<p><a href="/#narrow/stream/1-check/topic">invalid</a></p>');
648648

649649
await tapText(tester, find.text('invalid'));
@@ -748,28 +748,28 @@ void main() {
748748
});
749749

750750
group('MessageImageEmoji', () {
751-
Future<void> prepareContent(WidgetTester tester, String html) async {
751+
Future<void> prepare(WidgetTester tester, String html) async {
752752
await prepareContentBare(tester, plainContent(html),
753753
// We try to resolve image-emoji URLs on the self-account's realm.
754754
// For URLs on the self-account's realm, we include the auth credential.
755755
wrapWithPerAccountStoreWidget: true);
756756
}
757757

758758
testWidgets('smoke: custom emoji', (tester) async {
759-
await prepareContent(tester, ContentExample.emojiCustom.html);
759+
await prepare(tester, ContentExample.emojiCustom.html);
760760
tester.widget(find.byType(MessageImageEmoji));
761761
debugNetworkImageHttpClientProvider = null;
762762
});
763763

764764
testWidgets('smoke: custom emoji with invalid URL', (tester) async {
765-
await prepareContent(tester, ContentExample.emojiCustomInvalidUrl.html);
765+
await prepare(tester, ContentExample.emojiCustomInvalidUrl.html);
766766
final url = tester.widget<MessageImageEmoji>(find.byType(MessageImageEmoji)).node.src;
767767
check(() => Uri.parse(url)).throws();
768768
debugNetworkImageHttpClientProvider = null;
769769
});
770770

771771
testWidgets('smoke: Zulip extra emoji', (tester) async {
772-
await prepareContent(tester, ContentExample.emojiZulipExtra.html);
772+
await prepare(tester, ContentExample.emojiZulipExtra.html);
773773
tester.widget(find.byType(MessageImageEmoji));
774774
debugNetworkImageHttpClientProvider = null;
775775
});

0 commit comments

Comments
 (0)