Skip to content

Commit 40ac6de

Browse files
committed
sticky_header [nfc]: Cut redundant assert on header size
It's already a fact that the header's size in each dimension is non-negative and finite; the framework asserts that in the `layout` implementation (via debugAssertDoesMeetConstraints). So that includes `headerExtent`; and then `paintedHeaderSize` is bounded to between zero and that value.
1 parent 40bc4bc commit 40ac6de

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

lib/widgets/sticky_header.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -566,8 +566,8 @@ class _RenderSliverStickyHeaderList extends RenderSliver with RenderSliverHelper
566566

567567
if (header != null) {
568568
header!.layout(constraints.asBoxConstraints(), parentUsesSize: true);
569-
570569
final headerExtent = header!.size.onAxis(constraints.axis);
570+
571571
final double headerOffset;
572572
if (_headerEndBound == null) {
573573
// The header's item has [StickyHeaderItem.allowOverflow] true.
@@ -578,8 +578,6 @@ class _RenderSliverStickyHeaderList extends RenderSliver with RenderSliverHelper
578578
final paintedHeaderSize = calculatePaintOffset(constraints, from: 0, to: headerExtent);
579579
final cacheExtent = calculateCacheOffset(constraints, from: 0, to: headerExtent);
580580

581-
assert(0 <= paintedHeaderSize && paintedHeaderSize.isFinite);
582-
583581
geometry = SliverGeometry( // TODO review interaction with other slivers
584582
scrollExtent: geometry.scrollExtent,
585583
layoutExtent: geometry.layoutExtent,

0 commit comments

Comments
 (0)