Skip to content

Commit 28c4539

Browse files
fombalangHanson
authored and
Hanson
committed
autocomplete test [nfc]: Fix brittle avatar image finder
Add `findAvatarImage` to check userId instead of URL, making it resilient to changes in avatar image details like size. Previous finder used 'findNetworkImage' which would fail if the avatar size is different Relevant Discussion: https://chat.zulip.org/#narrow/channel/516-mobile-dev-help/topic/ComposeAutocomplete.20test.20failure.20help #995 (comment)
1 parent 30ce4a0 commit 28c4539

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

test/widgets/autocomplete_test.dart

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import 'package:zulip/model/localizations.dart';
1313
import 'package:zulip/model/narrow.dart';
1414
import 'package:zulip/model/store.dart';
1515
import 'package:zulip/model/typing_status.dart';
16+
import 'package:zulip/widgets/content.dart';
1617
import 'package:zulip/widgets/message_list.dart';
1718

1819
import '../api/fake_api.dart';
@@ -126,10 +127,13 @@ void main() {
126127
TestZulipBinding.ensureInitialized();
127128

128129
group('@-mentions', () {
130+
131+
Finder findAvatarImage(int userId) =>
132+
find.byWidgetPredicate((widget) => widget is AvatarImage && widget.userId == userId);
133+
129134
void checkUserShown(User user, PerAccountStore store, {required bool expected}) {
130135
check(find.text(user.fullName).evaluate().length).equals(expected ? 1 : 0);
131-
final avatarFinder =
132-
findNetworkImage(store.tryResolveUrl(user.avatarUrl!).toString());
136+
final avatarFinder = findAvatarImage(user.userId);
133137
check(avatarFinder.evaluate().length).equals(expected ? 1 : 0);
134138
}
135139

0 commit comments

Comments
 (0)