Skip to content

Commit 21dbae1

Browse files
committed
ui: Use 0xfff6f6f6 for ColorScheme.background, following Figma
From logging, this would otherwise be 0xfffefbff. See the Flutter doc on ColorScheme.background: https://api.flutter.dev/flutter/material/ColorScheme/background.html It simply says: > A color that typically appears behind scrollable content. This change is definitely the boldest we've been in perceiving a pattern in the Figma spec and organizing our code to fit it. We should cheerfully do something else if it turns out to make it harder instead of easier to follow the spec. Prompted by noticing that the surface underneath the scrollable content in RecentDmConversationsPage wasn't colored according to the Figma. And that the Figma's design for the Inbox page (#117) had the same color for the surface underneath *its* scrollable content. This change fixes the RecentDmConversationsPage and makes it easy and natural for the Inbox page to get the right color too.
1 parent 2f01c51 commit 21dbae1

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

lib/widgets/app.dart

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,13 @@ class ZulipApp extends StatelessWidget {
100100
// https://api.flutter.dev/flutter/material/ColorScheme/ColorScheme.fromSeed.html
101101
// Or try this tool to see the whole palette:
102102
// https://m3.material.io/theme-builder#/custom
103-
colorScheme: ColorScheme.fromSeed(seedColor: kZulipBrandColor),
103+
colorScheme: ColorScheme.fromSeed(
104+
seedColor: kZulipBrandColor,
105+
106+
// Used in the Figma for surfaces underneath scrollable content, e.g.:
107+
// <https://www.figma.com/file/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=341%3A12362&mode=dev>
108+
background: const Color(0xfff6f6f6),
109+
),
104110
// `preferBelow: false` seems like a better default for mobile;
105111
// the area below a long-press target seems more likely to be hidden by
106112
// a finger or thumb than the area above.

0 commit comments

Comments
 (0)