autocomplete [nfc]: Add silent to MentionAutocompleteQuery

As it does in the web app, we'll want this bit to control the
suggestion filtering: if the user wants a silent mention, then it
won't make sense to offer wildcard mentions in the list (@ALL,
@everyone, etc.).

Author: chrisbobbe

lib/model/autocomplete.dart

@@ -34,7 +34,7 @@ extension Autocomplete on ContentTextEditingController {
       if (match != null) {
         return AutocompleteIntent(
           syntaxStart: position,
-          query: MentionAutocompleteQuery(match[1]!),
+          query: MentionAutocompleteQuery(match[2]!, silent: match[1]! == '_'),
           textEditingValue: value);
       }
     }
@@ -57,7 +57,7 @@ final RegExp mentionAutocompleteMarkerRegex = (() {
 
   return RegExp(
     beforeAtSign
-    + r'@_?'
+    + r'@(_?)' // capture, so we can distinguish silent mentions
     + r'(|'
       // Reject on whitespace right after "@" or "@_". Emails can't start with
       // it, and full_name can't either (it's run through Python's `.strip()`).
@@ -271,11 +271,14 @@ class MentionAutocompleteView extends ChangeNotifier {
 }
 
 class MentionAutocompleteQuery {
-  MentionAutocompleteQuery(this.raw)
+  MentionAutocompleteQuery(this.raw, {this.silent = false})
     : _lowercaseWords = raw.toLowerCase().split(' ');
 
   final String raw;
 
+  /// Whether the user wants a silent mention (@_query, vs. @query).
+  final bool silent;
+
   final List<String> _lowercaseWords;
 
   bool testUser(User user, AutocompleteDataCache cache) {
@@ -303,16 +306,16 @@ class MentionAutocompleteQuery {
 
   @override
   String toString() {
-    return '${objectRuntimeType(this, 'MentionAutocompleteQuery')}(raw: $raw})';
+    return '${objectRuntimeType(this, 'MentionAutocompleteQuery')}(raw: $raw, silent: $silent})';
   }
 
   @override
   bool operator ==(Object other) {
-    return other is MentionAutocompleteQuery && other.raw == raw;
+    return other is MentionAutocompleteQuery && other.raw == raw && other.silent == silent;
   }
 
   @override
-  int get hashCode => Object.hash('MentionAutocompleteQuery', raw);
+  int get hashCode => Object.hash('MentionAutocompleteQuery', raw, silent);
 }
 
 class AutocompleteDataCache {

test/model/autocomplete_test.dart

@@ -81,7 +81,8 @@ void main() {
       });
     }
 
-    MentionAutocompleteQuery queryOf(String raw) => MentionAutocompleteQuery(raw);
+    MentionAutocompleteQuery queryOf(String raw) => MentionAutocompleteQuery(raw, silent: false);
+    MentionAutocompleteQuery silentQueryOf(String raw) => MentionAutocompleteQuery(raw, silent: true);
 
     doTest('', null);
     doTest('^', null);
@@ -120,36 +121,36 @@ void main() {
 
     doTest('~@^_', queryOf('')); // Odd/unlikely, but should not crash
 
-    doTest('~@__^', queryOf('_'));
+    doTest('~@__^', silentQueryOf('_'));
 
-    doTest('~@^abc^', queryOf('abc')); doTest('~@_^abc^', queryOf('abc'));
-    doTest('~@a^bc^', queryOf('abc')); doTest('~@_a^bc^', queryOf('abc'));
-    doTest('~@ab^c^', queryOf('abc')); doTest('~@_ab^c^', queryOf('abc'));
-    doTest('~^@^', queryOf(''));       doTest('~^@_^', queryOf(''));
+    doTest('~@^abc^', queryOf('abc')); doTest('~@_^abc^', silentQueryOf('abc'));
+    doTest('~@a^bc^', queryOf('abc')); doTest('~@_a^bc^', silentQueryOf('abc'));
+    doTest('~@ab^c^', queryOf('abc')); doTest('~@_ab^c^', silentQueryOf('abc'));
+    doTest('~^@^', queryOf(''));       doTest('~^@_^', silentQueryOf(''));
     // but:
     doTest('^hello @chris^', null);    doTest('^hello @_chris^', null);
 
-    doTest('~@abc^', queryOf('abc'));   doTest('~@_abc^', queryOf('abc'));
-    doTest(' ~@abc^', queryOf('abc'));  doTest(' ~@_abc^', queryOf('abc'));
-    doTest('(~@abc^', queryOf('abc'));  doTest('(~@_abc^', queryOf('abc'));
-    doTest('—~@abc^', queryOf('abc'));  doTest('—~@_abc^', queryOf('abc'));
-    doTest('"~@abc^', queryOf('abc'));  doTest('"~@_abc^', queryOf('abc'));
-    doTest('“~@abc^', queryOf('abc'));  doTest('“~@_abc^', queryOf('abc'));
-    doTest('。~@abc^', queryOf('abc')); doTest('。~@_abc^', queryOf('abc'));
-    doTest('«~@abc^', queryOf('abc'));  doTest('«~@_abc^', queryOf('abc'));
+    doTest('~@abc^', queryOf('abc'));   doTest('~@_abc^', silentQueryOf('abc'));
+    doTest(' ~@abc^', queryOf('abc'));  doTest(' ~@_abc^', silentQueryOf('abc'));
+    doTest('(~@abc^', queryOf('abc'));  doTest('(~@_abc^', silentQueryOf('abc'));
+    doTest('—~@abc^', queryOf('abc'));  doTest('—~@_abc^', silentQueryOf('abc'));
+    doTest('"~@abc^', queryOf('abc'));  doTest('"~@_abc^', silentQueryOf('abc'));
+    doTest('“~@abc^', queryOf('abc'));  doTest('“~@_abc^', silentQueryOf('abc'));
+    doTest('。~@abc^', queryOf('abc')); doTest('。~@_abc^', silentQueryOf('abc'));
+    doTest('«~@abc^', queryOf('abc'));  doTest('«~@_abc^', silentQueryOf('abc'));
 
-    doTest('~@ab^c', queryOf('ab')); doTest('~@_ab^c', queryOf('ab'));
-    doTest('~@a^bc', queryOf('a'));  doTest('~@_a^bc', queryOf('a'));
-    doTest('~@^abc', queryOf(''));   doTest('~@_^abc', queryOf(''));
-    doTest('~@^', queryOf(''));      doTest('~@_^', queryOf(''));
+    doTest('~@ab^c', queryOf('ab')); doTest('~@_ab^c', silentQueryOf('ab'));
+    doTest('~@a^bc', queryOf('a'));  doTest('~@_a^bc', silentQueryOf('a'));
+    doTest('~@^abc', queryOf(''));   doTest('~@_^abc', silentQueryOf(''));
+    doTest('~@^', queryOf(''));      doTest('~@_^', silentQueryOf(''));
 
-    doTest('Please ask ~@chris^', queryOf('chris'));             doTest('Please ask ~@_chris^', queryOf('chris'));
-    doTest('Please ask ~@chris bobbe^', queryOf('chris bobbe')); doTest('Please ask ~@_chris bobbe^', queryOf('chris bobbe'));
+    doTest('Please ask ~@chris^', queryOf('chris'));             doTest('Please ask ~@_chris^', silentQueryOf('chris'));
+    doTest('Please ask ~@chris bobbe^', queryOf('chris bobbe')); doTest('Please ask ~@_chris bobbe^', silentQueryOf('chris bobbe'));
 
     doTest('~@Rodion Romanovich Raskolnikov^', queryOf('Rodion Romanovich Raskolnikov'));
-    doTest('~@_Rodion Romanovich Raskolniko^', queryOf('Rodion Romanovich Raskolniko'));
+    doTest('~@_Rodion Romanovich Raskolniko^', silentQueryOf('Rodion Romanovich Raskolniko'));
     doTest('~@Родион Романович Раскольников^', queryOf('Родион Романович Раскольников'));
-    doTest('~@_Родион Романович Раскольнико^', queryOf('Родион Романович Раскольнико'));
+    doTest('~@_Родион Романович Раскольнико^', silentQueryOf('Родион Романович Раскольнико'));
     doTest('If @chris is around, please ask him.^', null); // @ sign is too far away from cursor
     doTest('If @_chris is around, please ask him.^', null); // @ sign is too far away from cursor
   });