Skip to content

Commit c20bfbd

Browse files
committed
Merge remote-tracking branch 'upstream/main'
* upstream/main: Revert "packages: Calculate package size quota using package creator ID instead of owner ID (go-gitea#28007)" (go-gitea#28049) Restricted users only see repos in orgs which their team was assigned to (go-gitea#28025) Fix release link in changelog for v1.21.0 Add v1.21.0 changelog (go-gitea#28005) Fix viewing wiki commit on empty repo (go-gitea#28040) Add word break to the repo list in admin settings page (go-gitea#28034)
2 parents 4c78dfc + f65977d commit c20bfbd

File tree

6 files changed

+458
-22
lines changed

6 files changed

+458
-22
lines changed

CHANGELOG.md

Lines changed: 448 additions & 1 deletion
Large diffs are not rendered by default.

models/packages/package_file.go

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -230,15 +230,3 @@ func CalculateFileSize(ctx context.Context, opts *PackageFileSearchOptions) (int
230230
Join("INNER", "package_blob", "package_blob.id = package_file.blob_id").
231231
SumInt(new(PackageBlob), "size")
232232
}
233-
234-
// CalculateCreatorPackageQuota sums up all blob sizes related to package
235-
// version creator id.
236-
// It does NOT respect the deduplication of blobs.
237-
func CalculateCreatorPackageQuota(ctx context.Context, creatorID int64) (int64, error) {
238-
return db.GetEngine(ctx).
239-
Table("package_version").
240-
Where(builder.Eq{"creator_id": creatorID}).
241-
Join("INNER", "package_file", "package_version.id = package_file.version_id").
242-
Join("INNER", "package_blob", "package_blob.id = package_file.blob_id").
243-
SumInt(new(PackageBlob), "size")
244-
}

models/repo/repo_list.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -652,12 +652,12 @@ func AccessibleRepositoryCondition(user *user_model.User, unitType unit.Type) bu
652652
userOrgTeamUnitRepoCond("`repository`.id", user.ID, unitType),
653653
)
654654
}
655-
cond = cond.Or(
656-
// 4. Repositories that we directly own
657-
builder.Eq{"`repository`.owner_id": user.ID},
655+
// 4. Repositories that we directly own
656+
cond = cond.Or(builder.Eq{"`repository`.owner_id": user.ID})
657+
if !user.IsRestricted {
658658
// 5. Be able to see all public repos in private organizations that we are an org_user of
659-
userOrgPublicRepoCond(user.ID),
660-
)
659+
cond = cond.Or(userOrgPublicRepoCond(user.ID))
660+
}
661661
}
662662

663663
return cond

routers/web/repo/middlewares.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import (
1616
// SetEditorconfigIfExists set editor config as render variable
1717
func SetEditorconfigIfExists(ctx *context.Context) {
1818
if ctx.Repo.Repository.IsEmpty {
19-
ctx.Data["Editorconfig"] = nil
2019
return
2120
}
2221

services/packages/packages.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,9 @@ func CheckSizeQuotaExceeded(ctx context.Context, doer, owner *user_model.User, p
401401
}
402402

403403
if setting.Packages.LimitTotalOwnerSize > -1 {
404-
totalSize, err := packages_model.CalculateCreatorPackageQuota(ctx, doer.ID)
404+
totalSize, err := packages_model.CalculateFileSize(ctx, &packages_model.PackageFileSearchOptions{
405+
OwnerID: owner.ID,
406+
})
405407
if err != nil {
406408
log.Error("CalculateFileSize failed: %v", err)
407409
return err

templates/admin/repo/list.tmpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,13 @@
4747
<tr>
4848
<td>{{.ID}}</td>
4949
<td>
50-
<a href="{{.Owner.HomeLink}}">{{.Owner.Name}}</a>
50+
<a class="gt-word-break" href="{{.Owner.HomeLink}}">{{.Owner.Name}}</a>
5151
{{if .Owner.Visibility.IsPrivate}}
5252
<span class="text gold">{{svg "octicon-lock"}}</span>
5353
{{end}}
5454
</td>
5555
<td>
56-
<a href="{{.Link}}">{{.Name}}</a>
56+
<a class="gt-word-break" href="{{.Link}}">{{.Name}}</a>
5757
{{if .IsArchived}}
5858
<span class="ui basic label">{{ctx.Locale.Tr "repo.desc.archived"}}</span>
5959
{{end}}

0 commit comments

Comments
 (0)