Skip to content

Commit 67a0872

Browse files
committed
Merge remote-tracking branch 'original-ts-origin/master'
# Conflicts: # packages/react-scripts/config/jest/typescriptTransform.js # packages/react-scripts/package.json # packages/react-scripts/scripts/utils/createJestConfig.js
2 parents bbce032 + 5bbeb43 commit 67a0872

File tree

5 files changed

+19
-6
lines changed

5 files changed

+19
-6
lines changed

ISSUE_TEMPLATE.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ Tell us what actually happens.
3636

3737
Run these commands in the project folder and fill in their results:
3838

39-
1. `npm ls react-scripts` (if you haven’t ejected):
39+
1. `npm ls react-scripts-ts` (if you haven’t ejected):
4040
2. `node -v`:
4141
3. `npm -v`:
4242

README.md

+14
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,20 @@ When you run `npm run build` the terminal will output the error, including the h
3131

3232
## Changelog
3333

34+
### 2.3.2
35+
* Fix `typescript` version to 2.3.x until 2.4 @types are fixed
36+
37+
### 2.3.1
38+
* Fix issue with new @types/react
39+
40+
### 2.3.0
41+
* All tsc to parse config (for `extend`) - Thanks to @DorianGrey
42+
* Fix various jest issues - thanks to @zinserjan
43+
* Fix code coverage - thanks to @zinserjan
44+
45+
### 2.2.0
46+
* Upgrade to [`[email protected]`](https://github.com/facebookincubator/create-react-app/)
47+
3448
### 2.1.0
3549
* Update to `[email protected]` - thanks to @mindjuice
3650
* Fix test setup issue - thanks to @jonmpqts

packages/react-scripts/config/jest/typescriptTransform.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ let compilerConfig = {
1515

1616
if (fs.existsSync(tsconfigPath)) {
1717
try {
18-
const tsconfig = require(tsconfigPath);
18+
const tsconfig = tsc.readConfigFile(tsconfigPath).config;
1919

2020
if (tsconfig && tsconfig.compilerOptions) {
2121
compilerConfig = tsconfig.compilerOptions;
@@ -29,14 +29,13 @@ module.exports = {
2929
process(src, path, config, options) {
3030
if (path.endsWith('.ts') || path.endsWith('.tsx')) {
3131
let compilerOptions = compilerConfig;
32-
// inline source with source map for remapping coverage
3332
if (options.instrument) {
33+
// inline source with source map for remapping coverage
3434
compilerOptions = Object.assign({}, compilerConfig);
3535
delete compilerOptions.sourceMap;
3636
compilerOptions.inlineSourceMap = true;
3737
compilerOptions.inlineSources = true;
3838
// fix broken paths in coverage report if `.outDir` is set
39-
// e.g. src/file:/Users/zinserjan/Projects/Github/react-typescript-starter/src
4039
delete compilerOptions.outDir;
4140
}
4241

packages/react-scripts/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
"tslint": "^5.2.0",
5252
"tslint-loader": "^3.5.3",
5353
"tslint-react": "^3.0.0",
54-
"typescript": "^2.3.3",
54+
"typescript": "~2.3.3",
5555
"source-map-loader": "^0.2.1",
5656
"sw-precache-webpack-plugin": "0.9.1",
5757
"typings-for-css-modules-loader": "1.5.0",

packages/react-scripts/template/src/App.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import "./App.css";
33

44
const logo = require("./logo.svg");
55

6-
class App extends React.Component<{}, null> {
6+
class App extends React.Component<{}, {}> {
77
render() {
88
return (
99
<div className="App">

0 commit comments

Comments
 (0)