-
Notifications
You must be signed in to change notification settings - Fork 927
Convert Schneider outlet to quirks v2, add missing controls #4521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4521 +/- ##
==========================================
+ Coverage 92.24% 92.29% +0.04%
==========================================
Files 369 371 +2
Lines 12094 12171 +77
==========================================
+ Hits 11156 11233 +77
Misses 938 938 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@nnae06 I don't have this device, so great that you can check it. I pushed fix for Local control mode that hopefully should resolve the issue. As for Indicator luminance level, not sure what else I can do there. Everything looks good to me according to the specification. |
|
The error seem to indicate that this attribute (0x0050) doesn't exist on your device, so I guess spec doc is incorrect, or has a mistake in it. Can you post signature of this device? To do that, go to "Manage Zigbee Device" -> "Signature" |
|
Actually, it doesn't look like signature will give us a list of attributes. Not sure if there is a way to get the list of attributes from manufacturer specific cluster. @TheJulianJES Let me know if you have some pointers, if not, I can remove se_local_control_mode attribute from the PR. |
|
{ |
|
Zigbee2Mqtt also doesn't have LocalControl attribute. Also their luminance level is enum, but spec says that it's uint8: |



Proposed change
Fixes: #4503
Part of: #1705
Additional information
Spec docs:
ZB Spec - Socket Outlets - 200522.pdf
Device diagnostics
Checklist
pre-commitchecks pass / the code has been formatted using Black