This repository was archived by the owner on Nov 26, 2025. It is now read-only.
Restore minor-mode-list across revert-buffer Calls in zig-format-buffer #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zig-format-buffer calls revert-buffer which ends up terminating minor modes like lsp. By saving the minor-mode-list context and then restoring it after the revert-buffer call (along with setting the PRESERVE-MODES parameter to true withint he call), we are able to retain the minor modes (like lsp) across calls to zig-format-buffer. This approach was inpsired by the following Github comment: emacs-lsp/lsp-mode#3469 (comment)
Contributor
joachimschmidt557
left a comment
joachimschmidt557
left a comment
There was a problem hiding this comment.
Thanks! I think this will fix a lot of issues with using revert-buffer. I do still believe though that in the long run we should transition away from formatting the file on disk towards formatting the buffer. This can be achieved through e.g. reformatter. I'll open a GitHub discussion about this.
Comment on lines
+161
to
+163
| (let ((active-minor-modes-list minor-mode-list)) | ||
| (revert-buffer :ignore-auto :noconfirm :preserve-modes) | ||
| (setq minor-mode-list active-minor-modes-list)))))))) |
Contributor
There was a problem hiding this comment.
This is nitpicky, but could you indent this with indent-tabs-mode off? It helps keep the indentation of this source consistent.
See also #65 (comment)
Contributor
|
#51 was merged a few weeks ago, which removes all usages of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zig-format-buffer calls revert-buffer which ends up terminating minor modes like lsp. By saving the minor-mode-list context and then restoring it after the revert-buffer call (along with setting the PRESERVE-MODES parameter to true within the call), we are able to retain the minor modes (like lsp) across calls to zig-format-buffer.
I believe this addresses the issue pointed out in #49. This approach was inspired by this Github comment.