Skip to content

fails to compile with Cython 0.19 #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cpcloud opened this issue Mar 9, 2013 · 6 comments · Fixed by #340
Closed

fails to compile with Cython 0.19 #339

cpcloud opened this issue Mar 9, 2013 · 6 comments · Fixed by #340

Comments

@cpcloud
Copy link

cpcloud commented Mar 9, 2013

I'm using arch linux with zmq version 3.2.2-2. I get the following error

zmq/core/message.pyx:49:30: Name '_check_rc' not declared in module 'zmq.core.checkrc'

Of course, it IS there but it's declared inline, which I think might be the issue although I'm not sure exactly why that would be. I know the pandas project has had some compilation issues with inlining Cython functions in the past, see pandas-dev/pandas#2188 for more info.

@minrk
Copy link
Member

minrk commented Mar 9, 2013

What's your Cython version?

@cpcloud
Copy link
Author

cpcloud commented Mar 9, 2013

0.19-dev

@minrk
Copy link
Member

minrk commented Mar 9, 2013

and this is pyzmq master?

@minrk
Copy link
Member

minrk commented Mar 9, 2013

Yup, Cython bug (or deliberate change, still unclear), and fixed by cython/cython#195. If that is rejected, the pyzmq fix is a single line, but I'd rather not apply it unless I hear that the new behavior is actually intentional for some reason.

@minrk
Copy link
Member

minrk commented Mar 9, 2013

As an aside, the inline function error is a red herring - the first error coming out of a compiler is often the only one that matters, in this case:

zmq/utils/buffers.pxd:165:27: default encoding required for conversion from 'char *' to 'str object'

which precedes the _check_rc message, which isn't an error at all, rather a symptom of invalid compiler state due to the first real error.

@minrk
Copy link
Member

minrk commented Mar 10, 2013

Looks like the new error is on purpose, so the appropriate patch is applied, and the build now works with latest Cython dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants