Skip to content

Commit bce0875

Browse files
committed
better format
1 parent 81ca64a commit bce0875

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

routers/common/logger_v2.go

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
package common
66

77
import (
8+
"fmt"
89
"net/http"
910
"time"
1011

@@ -53,36 +54,42 @@ func NewLoggerHandlerV2() func(next http.Handler) http.Handler {
5354
if trigger == LogRequestStart {
5455
// when a request starts, we have no information about the handler function information, we only have the request path
5556
_ = logger.Log(0, log.DEBUG, "router: started %v %s for %s", log.ColoredMethod(req.Method), req.RequestURI, req.RemoteAddr)
56-
} else if trigger == LogRequestExecuting {
57+
return
58+
}
59+
60+
handlerFuncInfo := fmt.Sprintf("%s:%d(%s)", funcFileShort, funcLine, funcNameShort)
61+
if trigger == LogRequestExecuting {
5762
message := "still-executing"
5863
level := log.WARN
5964
if isLongPolling {
6065
level = log.INFO
6166
message = "long-polling"
6267
}
63-
_ = logger.Log(0, level, "router: %s:%d(%s) %s %v %s for %s, elapsed %v",
64-
funcFileShort, funcLine, funcNameShort,
68+
_ = logger.Log(0, level, "router: %s %v %s for %s, elapsed %v @ %s",
6569
message,
6670
log.ColoredMethod(req.Method), req.RequestURI, req.RemoteAddr,
6771
log.ColoredTime(time.Since(reqRec.startTime)),
72+
handlerFuncInfo,
6873
)
6974
} else {
7075
if reqRec.panicError != nil {
71-
_ = logger.Log(0, log.WARN, "router: %s:%d(%s) failed %v %s for %s, panic in %v, err=%v",
76+
_ = logger.Log(0, log.WARN, "router: failed %v %s for %s, panic in %v @ %s, err=%v",
7277
funcFileShort, funcLine, funcNameShort,
7378
log.ColoredMethod(req.Method), req.RequestURI, req.RemoteAddr,
7479
log.ColoredTime(time.Since(reqRec.startTime)),
80+
handlerFuncInfo,
7581
reqRec.panicError,
7682
)
7783
} else {
7884
var status int
7985
if v, ok := reqRec.responseWriter.(gitea_context.ResponseWriter); ok {
8086
status = v.Status()
8187
}
82-
_ = logger.Log(0, log.INFO, "router: %s:%d(%s) completed %v %s for %s, %v %v in %v",
83-
funcFileShort, funcLine, funcNameShort,
88+
_ = logger.Log(0, log.INFO, "router: completed %v %s for %s, %v %v in %v @ %s",
8489
log.ColoredMethod(req.Method), req.RequestURI, req.RemoteAddr,
85-
log.ColoredStatus(status), log.ColoredStatus(status, http.StatusText(status)), log.ColoredTime(time.Since(reqRec.startTime)))
90+
log.ColoredStatus(status), log.ColoredStatus(status, http.StatusText(status)), log.ColoredTime(time.Since(reqRec.startTime)),
91+
handlerFuncInfo,
92+
)
8693
}
8794
}
8895
}

0 commit comments

Comments
 (0)