account for empty lines in receive-hook message (go-gitea#10773)

zeripath · lunny · jolheiser · web-flow · commit b3f4f812d818 · 2020-03-20T20:21:28.000+02:00
Co-authored-by: Lunny Xiao &lt;xiaolunwen@gmail.com&gt;
Co-authored-by: John Olheiser &lt;john.olheiser@gmail.com&gt;
diff --git a/models/error.go b/models/error.go
@@ -1423,7 +1423,7 @@ func (err *ErrPushRejected) GenerateMessage() {
 		}
 		i += 8
 		nl := strings.IndexByte(err.StdErr[i:], '\n')
-		if nl > 0 {
+		if nl >= 0 {
 			messageBuilder.WriteString(err.StdErr[i : i+nl+1])
 			i = i + nl + 1
 		} else {

Original file line number	Diff line number	Diff line change
`@@ -1423,7 +1423,7 @@ func (err *ErrPushRejected) GenerateMessage() {`
`1423`	`1423`	`}`
`1424`	`1424`	`i += 8`
`1425`	`1425`	`nl := strings.IndexByte(err.StdErr[i:], '\n')`
`1426`		`- if nl > 0 {`
	`1426`	`+ if nl >= 0 {`
`1427`	`1427`	`messageBuilder.WriteString(err.StdErr[i : i+nl+1])`
`1428`	`1428`	`i = i + nl + 1`
`1429`	`1429`	`} else {`