[Backport 27774 to v23] Fix various issues when validating DNS response packets #28788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Tweak west_setup:
- log `west update` to a file to reduce noise in log
- use `west forall` + `git reset` to make sure files are checked out
(this is to handle a possible module cache)
* Output when we start sanity_check. Add a banner for when we run
sanity_check so it's a bit easier to find in console logs
Signed-off-by: Kumar Gala <[email protected]>
Add setup to utilize buildkite for CI purposes:
1. .buildkite/hooks/pre-command:
* Handles getting git checkout setup against upstream repo
* Setup some west module cache (dirs, clean out files & locks)
* init dir for ccache
2. .buildkite/hooks/post-command:
* Report disk usage (meant for possible debugging)
3. .buildkite/pipeline.yml [uses to determine what to do]:
* setup zephyr env vars
* set which docker container to use
(export some local disk caches for git, west modules, and ccache)
* uses plug to general build annotation on failure (junit-annotate)
4. .buildkite/run.sh [ buildkite wrapper to invoke scripts/ci/run.sh ]
Signed-off-by: Kumar Gala <[email protected]>
The junit-annotate step will fail if there are no sanitycheck-*.xml files to be found which can happen if sanitycheck is run and does nothing (for example an update to .editorconfig). Try and create an empty sanitycheck.xml in such a case. Signed-off-by: Kumar Gala <[email protected]>
Move check_compliance script to main tree and adapt/use with GH actions. Signed-off-by: Anas Nashif <[email protected]>
This is not possible with valid DNS messages but is possible if we receive malformed DNS packet. Signed-off-by: Jukka Rissanen <[email protected]>
Make sure that IP address information is found in the received message. Signed-off-by: Jukka Rissanen <[email protected]>
As the answer might not be compressed, calculate next answer position correctly. Signed-off-by: Jukka Rissanen <[email protected]>
The ANCOUNT has nothing to do with label count so remove the original while loop and just go through all the labels until we have read all of them. Signed-off-by: Jukka Rissanen <[email protected]>
The DNS message must be long enough for id and flags fields. Signed-off-by: Jukka Rissanen <[email protected]>
Add more tests to verify that we discard malformed packets. In order to simplify the testing, separate message validation to dns_validate_msg() function in resolve.c. Allow that function to be called from unit test. This way we can construct invalid DNS messages in unit test and verify that they are discarded when needed. Signed-off-by: Jukka Rissanen <[email protected]> Signed-off-by: David Brown <[email protected]>
github-actions
bot
added
area: Networking
area: Tests
Contributor
Author
|
PR on wrong branch. Closing, will create new PR on correct branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #27774. The last commit (tests: net: dns: Add tests for catching malformed packets) had some conflicts, so it would be good to get extra scrutiny on review.