Fix + UTs

Author: yoanm

src/DependencyInjection/Configuration.php

@@ -26,7 +26,9 @@ public function getConfigTreeBuilder()
                     ->addDefaultsIfNotSet()
                     ->children()
                         ->booleanNode('enabled')
-                            ->info('Whether to render debug information on error or not (should NOT be enabled on prod)')
+                            ->info(
+                                'Whether to render debug information on error or not (should NOT be enabled on prod)'
+                            )
                             ->defaultFalse()
                         ->end()
                         ->integerNode('max_trace_size')

src/DependencyInjection/JsonRpcHttpServerExtension.php

@@ -230,8 +230,8 @@ private function checkMethodAwareServiceIdList(
     private function bindDebug(ContainerBuilder $container) : void
     {
         if ($container->getParameter(self::EXTENSION_IDENTIFIER.'.debug.enabled')) {
-            $container->getDefinition(self::EXTENSION_IDENTIFIER.'.app.serialization.jsonrpc_response_normalizer')
-                ->addArgument(new Reference(self::EXTENSION_IDENTIFIER.'.app.serialization.jsonrpc_response_error_normalizer'));
+            $container->getDefinition('json_rpc_server_sdk.app.serialization.jsonrpc_response_normalizer')
+                ->addArgument(new Reference('json_rpc_server_sdk.app.serialization.jsonrpc_response_error_normalizer'));
         }
     }
 }

tests/Functional/DependencyInjection/ConfigFilesTest.php

@@ -11,6 +11,7 @@
 use Yoanm\JsonRpcServer\App\Serialization\JsonRpcCallSerializer;
 use Yoanm\JsonRpcServer\App\Serialization\JsonRpcRequestDenormalizer;
 use Yoanm\JsonRpcServer\App\Serialization\JsonRpcResponseNormalizer;
+use Yoanm\JsonRpcServer\App\Serialization\JsonRpcResponseErrorNormalizer;
 use Yoanm\JsonRpcServer\Infra\Endpoint\JsonRpcEndpoint;
 use Yoanm\SymfonyJsonRpcHttpServer\DependencyInjection\JsonRpcHttpServerExtension;
 use Yoanm\SymfonyJsonRpcHttpServer\Dispatcher\SymfonyJsonRpcServerDispatcher;
@@ -100,6 +101,11 @@ public function provideSDKAppServiceIdAndClass()
                 'serviceClassName' => ResponseCreator::class,
                 'public' => false,
             ],
+            'SDK - App - Response error normalizer' => [
+                'serviceId' => 'json_rpc_server_sdk.app.serialization.jsonrpc_response_error_normalizer',
+                'serviceClassName' => JsonRpcResponseErrorNormalizer::class,
+                'public' => false,
+            ],
         ];
     }
 

tests/Functional/DependencyInjection/JsonRpcHttpServerExtensionTest.php

@@ -185,4 +185,22 @@ public function testShouldThowAnExceptionIfMethodAwareServiceDoesNotImplementRig
 
         $this->loadContainer();
     }
+
+    public function testShouldAddDebugResponseErrorNormalizerIfDebugModeEnabled()
+    {
+        $this->loadContainer([
+            'debug' => [
+                'enabled' => true,
+            ]
+        ]);
+
+        // Assert response normalizer has responseErrorNormalizer as first argument
+        $this->assertContainerBuilderHasServiceDefinitionWithArgument(
+            'json_rpc_server_sdk.app.serialization.jsonrpc_response_normalizer',
+            0,
+            new Reference('json_rpc_server_sdk.app.serialization.jsonrpc_response_error_normalizer'),
+        );
+
+        $this->assertEndpointIsUsable();
+    }
 }