Improve

Author: yoanm

.github/workflows/CI.yml

@@ -17,7 +17,6 @@ concurrency:
 env:
   # Cache params
   CACHE_VERSION: 2022061905 # To be able to create a new cache (YYYYMMDDXX)
-  COVERAGE_OUTPUT_STYLE: clover
   TEST_OUTPUT_STYLE: pretty
   COMPOSER_OPTIONS: --optimize-autoloader
   CODACY_CACHE_PATH: ~/.cache/codacy
@@ -35,6 +34,7 @@ jobs:
         with:
           php-version: '8.1'
           tools: composer
+          coverage: none
         env:
           # Always use latest available patch for the version
           update: true
@@ -59,28 +59,44 @@ jobs:
         uses: actions/dependency-review-action@v1
 
   tests:
-    name: UTs & FTs - PHP ${{ matrix.php-version }} / Symfony ${{ matrix.symfony-version }}
+    name: UTs & FTs - Symfony ${{ matrix.symfony-version }}
     runs-on: ubuntu-latest
+    env:
+      COVERAGE_TYPE: none
     strategy:
       fail-fast: true
       max-parallel: 4
       matrix:
         php-version:
           - '7.3' # Lowest supported
+          - '7.4' # Latest php 7 version
+          - '8.0' # First php 8 version
           - '8.1' # Latest supported
         symfony-version:
           - '4.4' # Lowest LTS
           - '5.4' # Latest LTS
+        exclude:
+          # Run all symfony version only on Lowest and Latest php versions, run it only one time for others
+          - php-version: '8.0'
+            symfony-version: '4.4'
+          - php-version: '7.4'
+            symfony-version: '5.4'
     steps:
       - name: Check out code
         uses: actions/checkout@v2
 
+      - name: Enable coverage
+        if: ${{ matrix.php-version == '8.1' }}
+        run: |
+          echo "COVERAGE_OUTPUT_STYLE=clover" >> $GITHUB_ENV
+          echo "COVERAGE_TYPE=xdebug" >> $GITHUB_ENV
+
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:
           php-version: '${{ matrix.php-version }}'
           tools: composer
-          coverage: xdebug
+          coverage: ${{ env.COVERAGE_TYPE }}
         env:
           # Always use latest available patch for the version
           update: true
@@ -107,7 +123,7 @@ jobs:
 
       - name: Build
         run: |
-          composer require \
+          composer require -W \
             symfony/http-foundation:^${{ matrix.symfony-version }} \
             symfony/http-kernel:^${{ matrix.symfony-version }} \
             symfony/config:^${{ matrix.symfony-version }} \
@@ -121,13 +137,16 @@ jobs:
 
       # See the reports at https://codecov.io/gh/yoanm/symfony-jsonrpc-http-server
       - name: Upload unit tests coverage to codecov
+        if: ${{ env.COVERAGE_TYPE == 'xdebug' }}
         uses: codecov/codecov-action@v3
         with:
           file: "build/coverage-phpunit/unit.clover"
           name: "unit-tests-${{ matrix.php-version }}-${{ matrix.symfony-version }}"
           flags: "unit-tests,php-${{ matrix.php-version }},sf-${{ matrix.symfony-version }}"
           fail_ci_if_error: true
+
       - name: Upload functional tests coverage to codecov
+        if: ${{ env.COVERAGE_TYPE == 'xdebug' }}
         uses: codecov/codecov-action@v3
         with:
           files: "build/coverage-behat/clover.xml,build/coverage-phpunit/functional.clover"
@@ -136,6 +155,7 @@ jobs:
           fail_ci_if_error: true
 
       - name: Upload coverages to Codacy
+        if: ${{ env.COVERAGE_TYPE == 'xdebug' }}
         run: ${{ env.CODACY_BIN }} report -r build/coverage-phpunit/unit.clover -r build/coverage-behat/clover.xml -r build/coverage-phpunit/functional.clover -t ${{ secrets.CODACY_PROJECT_TOKEN }} --partial
 
   finalize-codacy-coverage-report:
@@ -162,77 +182,16 @@ jobs:
       - name: Finalize reporting
         run: ${{ env.CODACY_BIN }} final -t ${{ secrets.CODACY_PROJECT_TOKEN }}
 
-  # Test against others impactful php versions (without coverage)
-  tests-extra-versions:
-    name: UTs & FTs - PHP ${{ matrix.php-version }} / Symfony ${{ matrix.symfony-version }}
-    runs-on: ubuntu-latest
-    needs: [ tests ]
-    strategy:
-      fail-fast: true
-      max-parallel: 4
-      matrix:
-        include:
-          - php-version: '7.4' # Latest php 7 version
-            symfony-version: '4.4'
-          - php-version: '8.0' # First php 8 version
-            symfony-version: '5.4'
-    steps:
-      - name: Check out code
-        uses: actions/checkout@v2
-
-      - name: Setup PHP
-        uses: shivammathur/setup-php@v2
-        with:
-          php-version: '${{ matrix.php-version }}'
-          tools: composer
-        env:
-          # Always use latest available patch for the version
-          update: true
-
-      - name: Setup cache
-        id: cache
-        uses: actions/cache@v2
-        with:
-          path: |
-            ~/.composer
-            ./vendor
-            ${{ env.CODACY_CACHE_PATH }}
-            build/behat-code-coverage-cache
-          # Clear the cache if composer json (as composer.lock is in the repo) has been updated
-          key: ${{ env.CACHE_VERSION }}-tests-${{ matrix.php-version }}-${{ matrix.symfony-version }}-${{ hashFiles('composer.json') }}
-
-      - name: Download codacy binary
-        if: steps.cache.outputs.cache-hit != 'true'
-        run: |
-          mkdir -p ${{ env.CODACY_CACHE_PATH }} \
-          && curl -LN https://coverage.codacy.com/get.sh -o ${{ env.CODACY_BIN }} \
-          && chmod +x ${{ env.CODACY_BIN }} \
-          && ${{ env.CODACY_BIN }} download
-
-      - name: Build
-        run: |
-          composer require \
-            symfony/http-foundation:^${{ matrix.symfony-version }} \
-            symfony/http-kernel:^${{ matrix.symfony-version }} \
-            symfony/config:^${{ matrix.symfony-version }} \
-            symfony/dependency-injection:^${{ matrix.symfony-version }} \
-            symfony/event-dispatcher:^${{ matrix.symfony-version }} \
-            symfony/routing:^${{ matrix.symfony-version }} \
-          && make build
-
-      - name: Tests
-        run: make test-unit && make test-functional
-
   # Perform tests against current php dev version and next Symfony minor version to manage
   nightly-tests:
-    name: Nightly - PHP ${{ matrix.php-version }} / Symfony ${{ matrix.symfony-version }}
-    needs: [ tests ]
+    name: Nightly - Symfony ${{ matrix.symfony-version }}
+    needs: [ static-tests, tests ]
     runs-on: ubuntu-latest
     env:
       COMPOSER_OPTIONS: '--optimize-autoloader --ignore-platform-req=php+'
     strategy:
       fail-fast: false
-      max-parallel: 2
+      max-parallel: 4
       matrix:
         php-version:
           - '8.2' # Current php dev version
@@ -252,7 +211,7 @@ jobs:
         with:
           php-version: '${{ matrix.php-version }}'
           tools: composer
-          coverage: xdebug
+          coverage: none
         env:
           # Always use latest available patch for the version
           update: true
@@ -271,7 +230,7 @@ jobs:
 
       - name: Build
         run: |
-          composer require ${COMPOSER_OPTIONS} \
+          composer require -W ${COMPOSER_OPTIONS} \
             symfony/http-foundation:^${{ matrix.symfony-version }} \
             symfony/http-kernel:^${{ matrix.symfony-version }} \
             symfony/config:^${{ matrix.symfony-version }} \
@@ -282,20 +241,3 @@ jobs:
 
       - name: Test
         run: make test-unit && make test-functional
-
-      # See the reports at https://codecov.io/gh/yoanm/symfony-jsonrpc-http-server
-      - name: Upload unit tests coverage to codecov
-        uses: codecov/codecov-action@v3
-        with:
-          file: "build/coverage-phpunit/unit.clover"
-          name: "unit-tests-${{ matrix.php-version }}-${{ matrix.symfony-version }}"
-          flags: "nightly,unit-tests,php-${{ matrix.php-version }},sf-${{ matrix.symfony-version }}"
-          fail_ci_if_error: false
-
-      - name: Upload functional tests coverage to codecov
-        uses: codecov/codecov-action@v3
-        with:
-          files: "build/coverage-behat/clover.xml,build/coverage-phpunit/functional.clover"
-          name: "functional-tests-${{ matrix.php-version }}-${{ matrix.symfony-version }}"
-          flags: "nightly,functional-tests,php-${{ matrix.php-version }},sf-${{ matrix.symfony-version }}"
-          fail_ci_if_error: false