Skip to content

Commit 2cb35f7

Browse files
authored
Test PHP 7.4 on Travis (#12)
1 parent 44e64c3 commit 2cb35f7

File tree

7 files changed

+12
-11
lines changed

7 files changed

+12
-11
lines changed

.travis.yml

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ php:
44
- '7.1'
55
- '7.2'
66
- '7.3'
7+
- '7.4'
78

89
env:
910
global:

composer.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,17 @@
3030
},
3131
"require": {
3232
"php": ">=7.1",
33-
"yoanm/jsonrpc-server-doc-sdk": "^0.1",
34-
"yoanm/jsonrpc-http-server-swagger-doc-sdk": "^0.1",
35-
"yoanm/symfony-jsonrpc-http-server-doc": "^0.1",
33+
"yoanm/jsonrpc-server-doc-sdk": "^0.2",
34+
"yoanm/jsonrpc-http-server-swagger-doc-sdk": "^0.2",
35+
"yoanm/symfony-jsonrpc-http-server-doc": "^0.2",
3636
"symfony/http-kernel": "^3.0 || ^4.0",
3737
"symfony/dependency-injection": "^3.0 || ^4.0"
3838
},
3939
"require-dev": {
4040
"behat/behat": "~3.0",
4141
"squizlabs/php_codesniffer": "3.*",
4242
"phpunit/phpunit": "^7.0 || ^8.0",
43-
"matthiasnoback/symfony-dependency-injection-test": "^2.0 || ^3.0",
43+
"matthiasnoback/symfony-dependency-injection-test": "^3.0 || ^4.0",
4444
"matthiasnoback/symfony-config-test": "^3.0 || ^4.0",
4545
"symfony/framework-bundle": "^3.0 || ^4.0",
4646
"yoanm/php-unit-extended": "~1.0"

tests/Common/DependencyInjection/AbstractTestClass.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,15 @@ abstract class AbstractTestClass extends AbstractExtensionTestCase
1919
/**
2020
* {@inheritdoc}
2121
*/
22-
protected function getContainerExtensions()
22+
protected function getContainerExtensions(): array
2323
{
2424
return [
2525
new JsonRpcHttpServerDocExtension(),
2626
new JsonRpcHttpServerSwaggerDocExtension()
2727
];
2828
}
2929

30-
protected function load(array $configurationValues = [])
30+
protected function loadContainer(array $configurationValues = []): void
3131
{
3232
$eventDispatcherDefinition = new Definition(EventDispatcher::class);
3333
$this->setDefinition('event_dispatcher', $eventDispatcherDefinition);

tests/Functional/DependencyInjection/ConfigFilesTest.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class ConfigFilesTest extends AbstractTestClass
3333
*/
3434
public function testShouldHaveService($serviceId, $expectedClassName, $public)
3535
{
36-
$this->load();
36+
$this->loadContainer();
3737

3838
$this->assertContainerBuilderHasService($serviceId, $expectedClassName);
3939
if (true === $public) {
@@ -44,7 +44,7 @@ public function testShouldHaveService($serviceId, $expectedClassName, $public)
4444

4545
public function testDocProviderShouldHaveDocProviderTag()
4646
{
47-
$this->load();
47+
$this->loadContainer();
4848

4949
// From yoanm/symfony-jsonrpc-http-server
5050
$this->assertContainerBuilderHasServiceDefinitionWithTag(

tests/Functional/DependencyInjection/JsonRpcHttpServerSwaggerDocExtensionTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ class JsonRpcHttpServerSwaggerDocExtensionTest extends AbstractTestClass
1111
{
1212
public function testShouldBeLoadable()
1313
{
14-
$this->load();
14+
$this->loadContainer();
1515

1616
$this->assertDocProviderIsLoadable();
1717
}

tests/Functional/Event/SwaggerDocCreatedEventTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class SwaggerDocCreatedEventTest extends TestCase
1919
/** @var HttpServerDoc|ObjectProphecy */
2020
private $serverDoc;
2121

22-
protected function setUp()
22+
protected function setUp(): void
2323
{
2424
$this->swaggerDoc = ['swaggerDoc'];
2525
$this->serverDoc = $this->prophesize(HttpServerDoc::class);

tests/Functional/Provider/DocProviderTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class DocProviderTest extends TestCase
2626
/** @var DocNormalizer|ObjectProphecy */
2727
private $docNormalizer;
2828

29-
protected function setUp()
29+
protected function setUp(): void
3030
{
3131
$this->dispatcher = $this->prophesize(EventDispatcherInterface::class);
3232
$this->httpServerDocCreator = $this->prophesize(HttpServerDocCreator::class);

0 commit comments

Comments
 (0)