Rename checksum to cumulative checksum

Author: robdrynkin

ydb/library/actors/interconnect/interconnect_channel.cpp

@@ -104,7 +104,7 @@ namespace NActors {
                     } else if (Params.UseExternalDataChannel && !SerializationInfo->Sections.empty()) {
                         State = EState::SECTIONS;
                         SectionIndex = 0;
-                        XXH3_64bits_reset(&RdmaChecksumState);
+                        XXH3_64bits_reset(&RdmaCumulativeChecksumState);
 
                         bool sendViaRdma = false;
                         // Check if any section can be send via rdma
@@ -352,7 +352,7 @@ namespace NActors {
                     return false;
                 }
                 if (checksumming) {
-                    XXH3_64bits_update(&RdmaChecksumState, buf.GetData(), buf.GetSize());
+                    XXH3_64bits_update(&RdmaCumulativeChecksumState, buf.GetData(), buf.GetSize());
                 }
                 auto cred = RdmaCredsBuffer.AddCreds();
                 cred->SetAddress(reinterpret_cast<ui64>(memReg.GetAddr()));
@@ -393,7 +393,7 @@ namespace NActors {
 
         Y_ABORT_UNLESS(RdmaCredsBuffer.SerializePartialToArray(ptr, credsSerializedSize));
         ptr += credsSerializedSize;
-        WriteUnaligned<ui32>(ptr, checksumming ? XXH3_64bits_digest(&RdmaChecksumState) : 0);
+        WriteUnaligned<ui32>(ptr, checksumming ? XXH3_64bits_digest(&RdmaCumulativeChecksumState) : 0);
         OutputQueueSize -= payloadSz;
 
         task.Write<false>(buffer, partSize);

ydb/library/actors/interconnect/interconnect_channel.h

@@ -152,7 +152,7 @@ namespace NActors {
         size_t SectionIndex = 0;
         std::vector<char> XdcData;
         std::shared_ptr<NInterconnect::NRdma::IMemPool> RdmaMemPool;
-        XXH3_state_t RdmaChecksumState;
+        XXH3_state_t RdmaCumulativeChecksumState;
 
         template<bool External>
         bool SerializeEvent(TTcpPacketOutTask& task, TEventHolder& event, size_t *bytesSerialized);

ydb/library/actors/interconnect/interconnect_tcp_input_session.cpp

@@ -803,9 +803,9 @@ namespace NActors {
                     Y_ABORT_UNLESS(creds.ParseFromArray(ptr, credsSerializedSize));
                     ptr += credsSerializedSize;
                     if (Params.ChecksumRdmaEvent) {
-                        context.PendingEvents.back().RdmaCheckSum = ReadUnaligned<ui32>(ptr);
+                        context.PendingEvents.back().RdmaCumulativeCheckSum = ReadUnaligned<ui32>(ptr);
                     } else {
-                        context.PendingEvents.back().RdmaCheckSum = 0;
+                        context.PendingEvents.back().RdmaCumulativeCheckSum = 0;
                     }
                     ptr += sizeof(ui32);
                     auto err = context.ScheduleRdmaReadRequests(creds, RdmaCq, SelfId(), channel);
@@ -903,7 +903,7 @@ namespace NActors {
                     throw TExReestablishConnection{TDisconnectReason::ChecksumError()};
                 }
             }
-            if (pendingEvent.RdmaCheckSum) {
+            if (pendingEvent.RdmaCumulativeCheckSum) {
                 XXH3_state_t state;
                 XXH3_64bits_reset(&state);
                 for (auto iter = payload.Begin(); iter.Valid(); ++iter) {
@@ -913,7 +913,7 @@ namespace NActors {
                     }
                 }
                 checksum = XXH3_64bits_digest(&state);
-                if (checksum != pendingEvent.RdmaCheckSum) {
+                if (checksum != pendingEvent.RdmaCumulativeCheckSum) {
                     LOG_CRIT_IC_SESSION("ICIS05", "event rdma checksum error Type# 0x%08" PRIx32, descr.Type);
                     throw TExReestablishConnection{TDisconnectReason::ChecksumError()};
                 }

ydb/library/actors/interconnect/interconnect_tcp_session.h

@@ -155,7 +155,7 @@ namespace NActors {
                 std::deque<NInterconnect::NRdma::TMemRegionSlice> RdmaBuffers;
                 TRdmaReadContext::TPtr RdmaReadContext = nullptr;
                 size_t RdmaSize = 0;
-                ui32 RdmaCheckSum = 0;
+                ui32 RdmaCumulativeCheckSum = 0;
             };
 
             std::deque<TPendingEvent> PendingEvents;