refactor(nm): return object with linkType and target #4143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larixer
requested changes
Feb 21, 2022
larixer
previously approved these changes
Feb 22, 2022
trivikr
changed the title
larixer
approved these changes
Feb 26, 2022
merceyz
pushed a commit
that referenced
this pull request
Oct 21, 2023
* refactor(nm): use const for linkType and target * yarn version check --interactive * fix: populate linkType and target as a tuple * chore: return object containing linkType and target (cherry picked from commit 26beba7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The variables
targetandlinkTypeare declared as let and their values are populated in an if-else.How did you fix it?
Change
targetandlinkTypeto const, and use a conditional (ternary) operator instead.Checklist