Skip to content

static defaultProps breaks prefer-stateless-function #1521

Closed
@evandavis

Description

@evandavis

The following is not caught by prefer-stateless-function:

import React from 'react';
import PropTypes from 'prop_types';

export default class Thing extends React.Component {
  static defaultProps = {
     foo: ''
  };

  static propTypes = {
    foo: PropTypes.string
  };

  render() {
    return <div>{this.props.foo}</div>;
  }
}

However, by removing static defaultProps, the error is reported:

import React from 'react';
import PropTypes from 'prop_types';

export default class Thing extends React.Component {
  static propTypes = {
    foo: PropTypes.string
  };

  render() {
    return <div>{this.props.foo}</div>;
  }
}

This is happening in 7.4.0.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions