Skip to content

Redundant buildExcelFile() Call in csv() Method #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yazansalhi opened this issue Jan 17, 2025 · 0 comments · Fixed by #191
Closed

Redundant buildExcelFile() Call in csv() Method #192

yazansalhi opened this issue Jan 17, 2025 · 0 comments · Fixed by #191

Comments

@yazansalhi
Copy link
Contributor

yazansalhi commented Jan 17, 2025 •
edited
Loading

Issue Description

The csv() method in the DataTable class calls buildExcelFile() twice, which introduces unnecessary processing.

Steps to Reproduce

  1. Observe the redundant call to buildExcelFile() in the code.

Expected Behavior

The method should call buildExcelFile() only once and reuse the result.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Avoid redundant call to buildExcelFile in csv method yazansalhi/laravel-datatables-buttons
1 participant
@yazansalhi