Skip to content

Commit 2820c90

Browse files
committed
Oracle 12.2+ supports 128 byte identifier length
```ruby $ ARCONN=oracle bin/test test/cases/migration/columns_test.rb -n test_rename_column_with_multi_column_index ... snip ... F Failure: ActiveRecord::Migration::ColumnsTest#test_rename_column_with_multi_column_index [/home/yahonda/git/rails/activerecord/test/cases/migration/columns_test.rb:113]: --- expected +++ actual @@ -1 +1 @@ -["i_test_models_hat_style_size"] +["index_test_models_on_hat_style_and_size"] ``` Kind of reverting rails#9395 Refer rsim/oracle-enhanced#1703
1 parent f4a30d2 commit 2820c90

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

activerecord/test/cases/migration/columns_test.rb

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -109,18 +109,10 @@ def test_rename_column_with_multi_column_index
109109
add_index "test_models", ["hat_style", "hat_size"], unique: true
110110

111111
rename_column "test_models", "hat_size", "size"
112-
if current_adapter? :OracleAdapter
113-
assert_equal ["i_test_models_hat_style_size"], connection.indexes("test_models").map(&:name)
114-
else
115-
assert_equal ["index_test_models_on_hat_style_and_size"], connection.indexes("test_models").map(&:name)
116-
end
112+
assert_equal ["index_test_models_on_hat_style_and_size"], connection.indexes("test_models").map(&:name)
117113

118114
rename_column "test_models", "hat_style", "style"
119-
if current_adapter? :OracleAdapter
120-
assert_equal ["i_test_models_style_size"], connection.indexes("test_models").map(&:name)
121-
else
122-
assert_equal ["index_test_models_on_style_and_size"], connection.indexes("test_models").map(&:name)
123-
end
115+
assert_equal ["index_test_models_on_style_and_size"], connection.indexes("test_models").map(&:name)
124116
end
125117

126118
def test_rename_column_does_not_rename_custom_named_index

0 commit comments

Comments
 (0)