From e5eb0f4c71f0df5c5af23cdd3f33add5c89c7d30 Mon Sep 17 00:00:00 2001 From: Erik Demaine Date: Wed, 6 Dec 2023 11:01:57 -0500 Subject: [PATCH 1/2] Fix with no contents Fixes #278 --- src/nodes/geometrynode.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nodes/geometrynode.ts b/src/nodes/geometrynode.ts index 5d3ba4cf..d3a44743 100644 --- a/src/nodes/geometrynode.ts +++ b/src/nodes/geometrynode.ts @@ -80,7 +80,7 @@ export abstract class GeometryNode extends GraphicsNode { protected getBoundingBoxCore(context: Context): Rect { const path = this.getCachedPath(context) - if (!path) { + if (!path || !path.segments.length) { return [0, 0, 0, 0] } let minX = Number.POSITIVE_INFINITY From 38a29437b4c0dc8be0d15258491b980ae1acdfe5 Mon Sep 17 00:00:00 2001 From: Erik Demaine Date: Thu, 7 Dec 2023 11:18:03 -0500 Subject: [PATCH 2/2] Add test --- test/common/tests.js | 1 + test/specs/svg-use-empty/reference.pdf | Bin 0 -> 3440 bytes test/specs/svg-use-empty/spec.svg | 6 ++++++ 3 files changed, 7 insertions(+) create mode 100644 test/specs/svg-use-empty/reference.pdf create mode 100644 test/specs/svg-use-empty/spec.svg diff --git a/test/common/tests.js b/test/common/tests.js index fa42728b..b4987013 100644 --- a/test/common/tests.js +++ b/test/common/tests.js @@ -55,6 +55,7 @@ window.tests = [ 'style-sheets', 'svg-viewbox', 'svg-use', + 'svg-use-empty', 'symbols', 'text-fill-stroke', 'text-placement', diff --git a/test/specs/svg-use-empty/reference.pdf b/test/specs/svg-use-empty/reference.pdf new file mode 100644 index 0000000000000000000000000000000000000000..91dbb605a42b0565aeb1e6802ff5bb2a49864c09 GIT binary patch literal 3440 zcmcIm?{3>T4F9gD;Fsby92!}2oIgWQpiP>txDDwg1vXr<4~nB^E*z<~m0f$!bWgCC z*&b!2Y`1Q_Ub;im8V*fUCiNpl{`SsB<9*Qz+1}T0|9)p71YqY^Y%t*Gch?&DnObUw z_e>iH0^d#j1R4GxGIOXw>mgr+AQef^jtV$ z{GB#S_ZdV#WN47POsf?OS~3U%8NuHyfD?AZ1bvb&47HTvRb5|Kqm1iXuzbp(_*8Mv zH2c5|THY{zG83@OQK}mh^3&epXZQ8G$bPgXkL zpW2l&J1B;F3;%gB6#jS96vXzXShzoRDox@Y?0eAxfag4o_0|5DeNBkcck<#5() zw#8?S0I|LK&F)rnoBrSL*Lzy5K(vrK9O96#jUn0WJs&6YD;?t;yx-K=W-AVR*%BzD0!KoWc4`w)qJ5S}}r zh?b&YS||(fXM{}9R#e{5SXBPd*ynaiK=b2UcQSLzX`oPv35g;IdRc<)UlHB$`S9x= zc#5pIXGCbRj&%mFu5!Xiw1QUf8WW53&L!52$kD6O8`1A|g%n8k=T74pd4)I+LVh8UDU=MZ|FMR zrmhz>ee|1aMbK&33DIxFEJE3cPqaG?zar{4Fc975K18qG{9eC{CG~i3GU#CfH*})g zz(q=`^9{RB*wl5YY%4pLsU$@*L?t~-{?U|QKDE|?q`Jb>acV9t_|m0^5nRB)ul|qQ Y!E;PLQElZ;WzJWY?4jqqz2nLF2ey8z`v3p{ literal 0 HcmV?d00001 diff --git a/test/specs/svg-use-empty/spec.svg b/test/specs/svg-use-empty/spec.svg new file mode 100644 index 00000000..a5fb1e36 --- /dev/null +++ b/test/specs/svg-use-empty/spec.svg @@ -0,0 +1,6 @@ + + + + + +