From 05aae37001069561cbb134ab392d0f4d30e3a0b7 Mon Sep 17 00:00:00 2001 From: Ian Sutherland Date: Thu, 1 Nov 2018 17:23:27 -0600 Subject: [PATCH 001/253] Add bot config (#4483) * Add stale config * Update stale config * Add lock config * Update lock.yml --- .github/lock.yml | 18 +++++++++++++++++ .github/stale.yml | 50 +++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 68 insertions(+) create mode 100644 .github/lock.yml create mode 100644 .github/stale.yml diff --git a/.github/lock.yml b/.github/lock.yml new file mode 100644 index 00000000000..4b055fd8e69 --- /dev/null +++ b/.github/lock.yml @@ -0,0 +1,18 @@ +# Configuration for lock-threads - https://github.com/dessant/lock-threads + +# Number of days of inactivity before a closed issue or pull request is locked +daysUntilLock: 7 +setLockReason: false + +issues: + # Comment to post when locking a stale Issue. + lockComment: > + The conversation for this issue has been locked because the issue is + closed. If you would like to contribute please open a new issue. + +pulls: +# Comment to post when locking a stale Pull Request. + lockComment: > + The conversation for this pull request has been locked because the pull + request is closed. If you would like to contribute please open a new pull + request. diff --git a/.github/stale.yml b/.github/stale.yml new file mode 100644 index 00000000000..bf7234bcd07 --- /dev/null +++ b/.github/stale.yml @@ -0,0 +1,50 @@ +# Configuration for probot-stale - https://github.com/probot/stale + +# Number of days of inactivity before an Issue or Pull Request becomes stale +daysUntilStale: 60 + +# Number of days of inactivity before a stale Issue or Pull Request is closed. +# Set to false to disable. If disabled, issues still need to be closed manually, but will remain marked as stale. +daysUntilClose: 7 + +# Issues or Pull Requests with these labels will never be considered stale. Set to `[]` to disable +exemptLabels: + - "issue: proposal" + - "issue: announcement" + +# Set to true to ignore issues in a project (defaults to false) +exemptProjects: true + +# Set to true to ignore issues in a milestone (defaults to false) +exemptMilestones: true + +# Label to use when marking as stale +staleLabel: stale + +# Limit the number of actions per hour, from 1-30. Default is 30 +limitPerRun: 30 + +issues: + # Comment to post when marking Issues as stale. + markComment: > + This issue has been automatically marked as stale because it has not had any + recent activity. It will be closed in 7 days if no further activity occurs. + + # Comment to post when closing a stale Issue. + closeComment: > + This issue has been automatically closed because it has not had any recent + activity. The conversation will be locked in 7 days unless the issue is + reopened. + +pulls: + # Comment to post when marking Pull Request as stale. + markComment: > + This pull request has been automatically marked as stale because it has not + had any recent activity. It will be closed in 7 days if no further activity + occurs. + + # Comment to post when closing a stale Pull Request. + closeComment: > + This pull request has been automatically closed because it has not had any + recent activity. The conversation will be locked in 7 days unless the pull + request is reopened. Thank you for your contribution. From 79ad49436784eb3fe00b3662c82a6e4f361e2f5e Mon Sep 17 00:00:00 2001 From: Trevor Brindle Date: Fri, 2 Nov 2018 10:28:42 -0400 Subject: [PATCH 002/253] update envinfo to 5.11.1 (#5685) --- packages/create-react-app/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/create-react-app/package.json b/packages/create-react-app/package.json index 3663ba510cb..b9f14f27706 100644 --- a/packages/create-react-app/package.json +++ b/packages/create-react-app/package.json @@ -25,7 +25,7 @@ "chalk": "1.1.3", "commander": "2.18.0", "cross-spawn": "4.0.2", - "envinfo": "5.10.0", + "envinfo": "5.11.1", "fs-extra": "5.0.0", "hyperquest": "2.1.3", "semver": "5.5.1", From 20be1b670779a93bcf58a8a6a4ba7e5682f25a00 Mon Sep 17 00:00:00 2001 From: Dennis Ushakov Date: Fri, 2 Nov 2018 18:24:50 +0300 Subject: [PATCH 003/253] ignore intellij module files when generating an app (#4605) --- packages/create-react-app/createReactApp.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/create-react-app/createReactApp.js b/packages/create-react-app/createReactApp.js index f0a2d23aba3..50bf9befd39 100755 --- a/packages/create-react-app/createReactApp.js +++ b/packages/create-react-app/createReactApp.js @@ -748,7 +748,6 @@ function isSafeToCreateProjectIn(root, name) { '.idea', 'README.md', 'LICENSE', - 'web.iml', '.hg', '.hgignore', '.hgcheck', @@ -764,6 +763,8 @@ function isSafeToCreateProjectIn(root, name) { const conflicts = fs .readdirSync(root) .filter(file => !validFiles.includes(file)) + // IntelliJ IDEA creates module files before CRA is launched + .filter(file => !/\.iml$/.test(file)) // Don't treat log files from previous installation as conflicts .filter( file => !errorLogFilePatterns.some(pattern => file.indexOf(pattern) === 0) From 3d8307f04307514c32530ea0c3c0855b79885898 Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Fri, 2 Nov 2018 18:04:54 -0400 Subject: [PATCH 004/253] Make stale bot configuration more aggressive --- .github/stale.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/stale.yml b/.github/stale.yml index bf7234bcd07..e14315ff838 100644 --- a/.github/stale.yml +++ b/.github/stale.yml @@ -1,11 +1,11 @@ # Configuration for probot-stale - https://github.com/probot/stale # Number of days of inactivity before an Issue or Pull Request becomes stale -daysUntilStale: 60 +daysUntilStale: 30 # Number of days of inactivity before a stale Issue or Pull Request is closed. # Set to false to disable. If disabled, issues still need to be closed manually, but will remain marked as stale. -daysUntilClose: 7 +daysUntilClose: 5 # Issues or Pull Requests with these labels will never be considered stale. Set to `[]` to disable exemptLabels: From 8a74ac577a9087cbae76bc54682c88bbe5a046f1 Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Fri, 2 Nov 2018 18:06:48 -0400 Subject: [PATCH 005/253] Lock issues more aggressively --- .github/lock.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/lock.yml b/.github/lock.yml index 4b055fd8e69..015721936d1 100644 --- a/.github/lock.yml +++ b/.github/lock.yml @@ -1,14 +1,14 @@ # Configuration for lock-threads - https://github.com/dessant/lock-threads # Number of days of inactivity before a closed issue or pull request is locked -daysUntilLock: 7 +daysUntilLock: 5 setLockReason: false issues: # Comment to post when locking a stale Issue. lockComment: > The conversation for this issue has been locked because the issue is - closed. If you would like to contribute please open a new issue. + closed. If you have a question or comment, please open a new issue. pulls: # Comment to post when locking a stale Pull Request. From aac14ea5798f991c96e94ff29a7797a823ca7196 Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Fri, 2 Nov 2018 19:25:56 -0400 Subject: [PATCH 006/253] Add permissive TS lib defaults (#5694) --- packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js b/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js index b1d6a5d71c9..538ce6e29bf 100644 --- a/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js +++ b/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js @@ -93,6 +93,7 @@ function verifyTypeScriptSetup() { parsedValue: ts.ScriptTarget.ES5, suggested: 'es5', }, + lib: ['dom', 'dom.iterable', 'esnext'], allowJs: { suggested: true }, skipLibCheck: { suggested: false }, esModuleInterop: { suggested: true }, From 5cdf36024635f58e2f36bd796dc36096c2f57191 Mon Sep 17 00:00:00 2001 From: Ian Schmitz Date: Sat, 3 Nov 2018 12:21:10 -0700 Subject: [PATCH 007/253] Fix tsconfig.json lib suggested value (#5701) --- packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js b/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js index 538ce6e29bf..8dd5cdcc69a 100644 --- a/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js +++ b/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js @@ -93,7 +93,7 @@ function verifyTypeScriptSetup() { parsedValue: ts.ScriptTarget.ES5, suggested: 'es5', }, - lib: ['dom', 'dom.iterable', 'esnext'], + lib: { suggested: ['dom', 'dom.iterable', 'esnext'] }, allowJs: { suggested: true }, skipLibCheck: { suggested: false }, esModuleInterop: { suggested: true }, From 8025a0ac9e2b0173c3d8836dcca035808bea6e96 Mon Sep 17 00:00:00 2001 From: Oleksandr Melnykov Date: Sun, 4 Nov 2018 21:03:04 +0100 Subject: [PATCH 008/253] Fix broken documentation link (#5670) Fix public folder documentation link --- docusaurus/docs/using-the-public-folder.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docusaurus/docs/using-the-public-folder.md b/docusaurus/docs/using-the-public-folder.md index 89a43fbca3b..56269d51335 100644 --- a/docusaurus/docs/using-the-public-folder.md +++ b/docusaurus/docs/using-the-public-folder.md @@ -7,7 +7,7 @@ title: Using the Public Folder ## Changing the HTML -The `public` folder contains the HTML file so you can tweak it, for example, to [set the page title](changing-the-page-title.md). +The `public` folder contains the HTML file so you can tweak it, for example, to [set the page title](title-and-meta-tags.md). The `