Skip to content

New option to exclude framework translations #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thanosalexandris opened this issue Aug 2, 2024 · 1 comment
Closed

New option to exclude framework translations #186

thanosalexandris opened this issue Aug 2, 2024 · 1 comment

Comments

@thanosalexandris
Copy link

Hey there.
Could it be easy to add an extra option in src/interfaces/plugin-options.ts like this

excludeFrameworkTranslations: boolean,

and then in src/vite.ts
to change it into

const excludeFrameworkTranslations = typeof options === 'string' ? options === 'lang' : options.excludeFrameworkTranslations ?? true
const frameworkLangPath = excludeFrameworkTranslations ? '' : 'vendor/laravel/framework/src/Illuminate/Translation/lang/'.replace('/', path.sep)

This way we'll be able to optionally skip framework translations, and having this php_en.json generated.

@xiCO2k
Copy link
Owner

xiCO2k commented Sep 3, 2024

Go ahead and make a PR for that, I will check.

Thanks for the suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants