-
Notifications
You must be signed in to change notification settings - Fork 41
should 'X', 'Y' be synonyms for 'longitude', 'latitude'? #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Based on what we've found in MetPy and in my own frequent use-case of gridded atmospheric data in projected spaces, I would argue that 'X', 'Y' should not be synonyms for 'longitude', 'latitude' in general. It is not uncommon that an 'X'/'Y' axis is present as a coordinate variable (CF terminology)/dimension coordinate (xarray terminology), but they are not 'longitude'/'latitude' (which is instead a 2D auxiliary coordinate variable/non-dimension coordinate). Both these types of coordinates are separately useful, and so, should ideally be available independently (although, in the special case of the plate carrée/ For some background, these were quasi-synonymous in MetPy (i.e. 'X' could access 'longitude' even if >1D, but would default to a suitable dimension coordinate if present), but that was changed with Unidata/MetPy#1090 / Unidata/MetPy#1236. I've been quite happy with how MetPy's been handling it since the change. |
Thanks for taking the time to comment @jthielen . I agree with the reasoning you outlined. I'll keep the issue open for visibility. |
@dcherian Sounds great, thanks! In writing up my comment, I was stuck by the difference in terminology between xarray and the CF conventions, so I also just submitted an issue for a doc page that may be worth considering (#25). I would be able to help with that at some point, but perhaps not immediately. |
This may be useful to have for reference: cf-convention/cf-conventions#133 |
Also related: pyproj4/pyproj#536 |
I am very unsure about this. Originally, they were synonyms. In 21c0387 I undid that.
Here is the current state of affairs
cf-xarray/cf_xarray/accessor.py
Lines 24 to 89 in 21c0387
Note that
'Z', 'T'
are synonymous with'vertical', 'time'
.This would be a good place for someone to chime in.
The text was updated successfully, but these errors were encountered: