Updates to HTTP request paths in preparation for removing prefix matching behaviour. #6732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
In addition, we've recently removed requests to /host_rrds and /vm_rrds that XenCenter was making (prefix-matched to /host_rrd and /vm_rrd) - should we add these for compatibility, and indicate that they should be eventually removed? |
robhoes
reviewed
Oct 29, 2025
lindig
approved these changes
Oct 29, 2025
cplaursen
force-pushed
the
fix_uris
branch
3 times, most recently
from
8e69e34 to
8b52a3b
Compare
robhoes
reviewed
Oct 29, 2025
Contributor
Author
|
Found some RBAC issues when running tests that I'm looking into. |
lindig
approved these changes
Oct 30, 2025
cplaursen
force-pushed
the
fix_uris
branch
2 times, most recently
from
62af0ed to
9fae088
Compare
Requests in the Http library store the request path under the "uri" field name - query parameters are stored separately. This is confusing and unhelpful; "path" is clearer and more accurate. Signed-off-by: Christian Pardillo Laursen <[email protected]>
PyRPC uses "/RPC2" by default, which is currently getting redirected to "/" by the prefix matching logic on routes. Adding this endpoint in preparation for removing the prefix matching. Signed-off-by: Christian Pardillo Laursen <[email protected]>
robhoes
reviewed
Nov 12, 2025
robhoes
requested changes
Nov 12, 2025
Member
robhoes
left a comment
robhoes
left a comment
There was a problem hiding this comment.
There's one mistake: see above. Other than that it looks good.
XenCenter was using the above paths erroneously until build 8460. Adding these paths for backwards compatibility. Signed-off-by: Christian Pardillo Laursen <[email protected]>
Signed-off-by: Christian Pardillo Laursen <[email protected]>
Contributor
Author
|
All done, thanks for spotting that. |
robhoes
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're looking to remove the prefix matching that our homebrew HTTP server does with routes, so I've updated a couple things in the code to remove any reliance on this behaviour. In particular: