CA-405643: Update DNF to DNF5 #6316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
liulinC
force-pushed
the
private/linl/dev
branch
from
065b6dc to
b4199b1
Compare
dnf has been updated to dnf5 during clean rebuild event for XS9, The command line interface changed and we need to update accordingly https://dnf5.readthedocs.io/en/latest/changes_from_dnf4.7.html Following commands update are necessary for DNF5 update - updateinfo -> advisory - config-manager "--save --setopt" -> "setopt" - reposync removed "--downloadcomps" as it is the default behavior - repoquery format output no longer has line breaker, add `\n` in format argument to bring it back and align with YUM - repoquery drop "-a" option as it is default behavior Also improve the code with strong type checking - Available|Updates for two kinds of updateinfo instead of string Signed-off-by: Lin Liu <[email protected]>
liulinC
force-pushed
the
private/linl/dev
branch
from
b4199b1 to
57eba37
Compare
Member
|
I'm urprised all this changes still work with XS8, is it using DNF5 interface in a backwards compatible fashion, so it works with both the old and the new cli interface? |
Collaborator
Author
No, XS8 use yum, thus, the command line interface compatibility is broken, |
Member
|
Ah, yes, I forgot xs8 wasn't using dnf at all |
psafont
approved these changes
Feb 24, 2025
lindig
approved these changes
Feb 24, 2025
| in | ||
| ignore (Helpers.call_script ~log_output:Helpers.On_failure cmd params) | ||
| let config_repo config = | ||
| if List.length config <> 0 then (* Set params to yum/dnf *) |
Contributor
There was a problem hiding this comment.
It would be better to test against [].
Collaborator
Author
There was a problem hiding this comment.
xenrt has covered that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dnf has been updated to dnf5 during clean rebuild event for XS9, The command line interface changed and we need to update accordingly https://dnf5.readthedocs.io/en/latest/changes_from_dnf4.7.html
Following commands update are necessary for DNF5 update
\nin format argument to bring it back and align with YUM