Skip to content

Conversation

@iamdharmesh
Copy link
Collaborator

Changes proposed in this Pull Request:

PR Updates the campaign options for Campaign, Ad group and Ad as suggested in issue here

Closes https://linear.app/a8c/issue/REDTWOO-87/adjust-campaign-settings-for-launch-of-feature

Steps to test the changes in this Pull Request:

  1. Install plugin.
  2. Connect Reddit account and Create campaign in second step of the onboarding. (Please make sure to test this will old and completely new Reddit account)
  3. Verify created campaign and make sure that Campaign, Ad groups and Ads are created with options suggested on the issue

Changelog entry

N/A

@iamdharmesh iamdharmesh self-assigned this Nov 26, 2025
@iamdharmesh iamdharmesh marked this pull request as ready for review November 26, 2025 13:43
@iamdharmesh
Copy link
Collaborator Author

Note: npm install fails due to some error with tracking package installation (getting 402 Payment Required error). So, some actions are failing on the PR.

Copy link
Collaborator

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamdharmesh I left some questions about targeting. Otherwise, I think this is looking ok.

$targeting_type = $campaign_data['targeting_type'] ?? '';

$shopping_targeting = array(
'targeting_type' => $targeting_type,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if $targeting_type is '' above? Is that ok?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, I just ignored this as we are passing hardcoded value in the function call. Updated this to use PROSPECTING as a default now.

@joemcgill
Copy link
Collaborator

Note: npm install fails due to some error with tracking package installation (getting 402 Payment Required error). So, some actions are failing on the PR.

These errors are related to the way this dependency is currently set up. This package has since been moved and the path can be updated similar to how it was done in this PR.

Copy link
Collaborator

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre approved assuming CI passes.

@ankitguptaindia
Copy link
Collaborator

QA Status: Need Feedback/Fixes ⚠️

@iamdharmesh While testing, I observed there are some errors when creating a campaign from the second step with an existing Reddit account; it has error as shown in the screenshot and campaign creation fails.

Screenshot 2025-11-27 at 9 56 56 PM
Recording.1569.mp4

@ankitguptaindia
Copy link
Collaborator

QA Status: Approved ✅

  • QA Round- 1 Status: Issue marked in the above comment fixes automatically. In today testing this issue no longer reproducible. Tried varuous ways to reproduce on new setup, existing setup, with new ad accounts and existing ads accounts.
  • QA Round- 2 Status: In this phase, perform various test cases and all cases work as expected. The detailed report is as follows.

New setup and new ads account

Recording.1573.mp4

Existing Setup with Existing Ads account:

Recording.1571.mp4

With a Specific Demographic country:

exisiting.setup.with.specific.demographic.area.mp4

Next Step: Ready to merge 🚀

@iamdharmesh iamdharmesh merged commit 2a8d94c into REDTWOO-61 Nov 28, 2025
9 checks passed
@iamdharmesh iamdharmesh deleted the REDTWOO-87 branch November 28, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants