From 6cfccf6c6dd300e79e986ecbd06b99ecd54acf54 Mon Sep 17 00:00:00 2001 From: Tim Jacobi Date: Thu, 20 Jul 2017 11:02:49 +0100 Subject: [PATCH 1/5] npm init --- .../ts-lint-create-react-app-typescript/package.json | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 packages/ts-lint-create-react-app-typescript/package.json diff --git a/packages/ts-lint-create-react-app-typescript/package.json b/packages/ts-lint-create-react-app-typescript/package.json new file mode 100644 index 000000000..6f681145e --- /dev/null +++ b/packages/ts-lint-create-react-app-typescript/package.json @@ -0,0 +1,12 @@ +{ + "name": "ts-lint-create-react-app-typescript", + "version": "1.0.0", + "description": "TS Lint configuration for create-react-app-typescript", + "license": "BSD-3-Clause", + "engines": { + "node": ">=6" + }, + "bugs": { + "url": "https://github.com/wmonk/create-react-app/issues" + } +} From 1f5dce60963973b5e601b5916bddd0b279f9cf43 Mon Sep 17 00:00:00 2001 From: Tim Jacobi Date: Thu, 20 Jul 2017 11:04:46 +0100 Subject: [PATCH 2/5] insert rules --- .../tslint.json | 98 +++++++++++++++++++ 1 file changed, 98 insertions(+) create mode 100644 packages/ts-lint-create-react-app-typescript/tslint.json diff --git a/packages/ts-lint-create-react-app-typescript/tslint.json b/packages/ts-lint-create-react-app-typescript/tslint.json new file mode 100644 index 000000000..759d3cd07 --- /dev/null +++ b/packages/ts-lint-create-react-app-typescript/tslint.json @@ -0,0 +1,98 @@ +{ + "rules": { + "align": [ + true, + "parameters", + "arguments", + "statements" + ], + "ban": false, + "class-name": true, + "comment-format": [ + true, + "check-space" + ], + "curly": true, + "eofline": false, + "forin": true, + "indent": [ true, "spaces" ], + "interface-name": [true, "never-prefix"], + "jsdoc-format": true, + "jsx-no-lambda": false, + "jsx-no-multiline-js": false, + "label-position": true, + "max-line-length": [ true, 120 ], + "member-ordering": [ + true, + "public-before-private", + "static-before-instance", + "variables-before-functions" + ], + "no-any": true, + "no-arg": true, + "no-bitwise": true, + "no-console": [ + true, + "log", + "error", + "debug", + "info", + "time", + "timeEnd", + "trace" + ], + "no-consecutive-blank-lines": true, + "no-construct": true, + "no-debugger": true, + "no-duplicate-variable": true, + "no-empty": true, + "no-eval": true, + "no-shadowed-variable": true, + "no-string-literal": true, + "no-switch-case-fall-through": true, + "no-trailing-whitespace": false, + "no-unused-expression": true, + "no-use-before-declare": true, + "one-line": [ + true, + "check-catch", + "check-else", + "check-open-brace", + "check-whitespace" + ], + "quotemark": [true, "single", "jsx-double"], + "radix": true, + "semicolon": [true, "always"], + "switch-default": true, + + "trailing-comma": false, + + "triple-equals": [ true, "allow-null-check" ], + "typedef": [ + true, + "parameter", + "property-declaration" + ], + "typedef-whitespace": [ + true, + { + "call-signature": "nospace", + "index-signature": "nospace", + "parameter": "nospace", + "property-declaration": "nospace", + "variable-declaration": "nospace" + } + ], + "variable-name": [true, "ban-keywords", "check-format", "allow-leading-underscore", "allow-pascal-case"], + "whitespace": [ + true, + "check-branch", + "check-decl", + "check-module", + "check-operator", + "check-separator", + "check-type", + "check-typecast" + ] + } +} From e181d866e08a7cb38b82f24fffcbe86f9dbe741e Mon Sep 17 00:00:00 2001 From: Tim Jacobi Date: Thu, 20 Jul 2017 11:05:27 +0100 Subject: [PATCH 3/5] change package name --- .../package.json | 2 +- .../tslint.json | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename packages/{ts-lint-create-react-app-typescript => tslint-create-react-app-typescript}/package.json (83%) rename packages/{ts-lint-create-react-app-typescript => tslint-create-react-app-typescript}/tslint.json (100%) diff --git a/packages/ts-lint-create-react-app-typescript/package.json b/packages/tslint-create-react-app-typescript/package.json similarity index 83% rename from packages/ts-lint-create-react-app-typescript/package.json rename to packages/tslint-create-react-app-typescript/package.json index 6f681145e..9d49bffe1 100644 --- a/packages/ts-lint-create-react-app-typescript/package.json +++ b/packages/tslint-create-react-app-typescript/package.json @@ -1,5 +1,5 @@ { - "name": "ts-lint-create-react-app-typescript", + "name": "tslint-create-react-app-typescript", "version": "1.0.0", "description": "TS Lint configuration for create-react-app-typescript", "license": "BSD-3-Clause", diff --git a/packages/ts-lint-create-react-app-typescript/tslint.json b/packages/tslint-create-react-app-typescript/tslint.json similarity index 100% rename from packages/ts-lint-create-react-app-typescript/tslint.json rename to packages/tslint-create-react-app-typescript/tslint.json From 77e5bd3b6f2df46f9072fa0f73e84438b48b179a Mon Sep 17 00:00:00 2001 From: Tim Jacobi Date: Thu, 20 Jul 2017 11:06:22 +0100 Subject: [PATCH 4/5] extend from newly created package --- packages/react-scripts/template/tslint.json | 98 +-------------------- 1 file changed, 1 insertion(+), 97 deletions(-) diff --git a/packages/react-scripts/template/tslint.json b/packages/react-scripts/template/tslint.json index 3339553ac..aaacad78e 100644 --- a/packages/react-scripts/template/tslint.json +++ b/packages/react-scripts/template/tslint.json @@ -1,99 +1,3 @@ { - "extends": ["tslint-react"], - "rules": { - "align": [ - true, - "parameters", - "arguments", - "statements" - ], - "ban": false, - "class-name": true, - "comment-format": [ - true, - "check-space" - ], - "curly": true, - "eofline": false, - "forin": true, - "indent": [ true, "spaces" ], - "interface-name": [true, "never-prefix"], - "jsdoc-format": true, - "jsx-no-lambda": false, - "jsx-no-multiline-js": false, - "label-position": true, - "max-line-length": [ true, 120 ], - "member-ordering": [ - true, - "public-before-private", - "static-before-instance", - "variables-before-functions" - ], - "no-any": true, - "no-arg": true, - "no-bitwise": true, - "no-console": [ - true, - "log", - "error", - "debug", - "info", - "time", - "timeEnd", - "trace" - ], - "no-consecutive-blank-lines": true, - "no-construct": true, - "no-debugger": true, - "no-duplicate-variable": true, - "no-empty": true, - "no-eval": true, - "no-shadowed-variable": true, - "no-string-literal": true, - "no-switch-case-fall-through": true, - "no-trailing-whitespace": false, - "no-unused-expression": true, - "no-use-before-declare": true, - "one-line": [ - true, - "check-catch", - "check-else", - "check-open-brace", - "check-whitespace" - ], - "quotemark": [true, "single", "jsx-double"], - "radix": true, - "semicolon": [true, "always"], - "switch-default": true, - - "trailing-comma": false, - - "triple-equals": [ true, "allow-null-check" ], - "typedef": [ - true, - "parameter", - "property-declaration" - ], - "typedef-whitespace": [ - true, - { - "call-signature": "nospace", - "index-signature": "nospace", - "parameter": "nospace", - "property-declaration": "nospace", - "variable-declaration": "nospace" - } - ], - "variable-name": [true, "ban-keywords", "check-format", "allow-leading-underscore", "allow-pascal-case"], - "whitespace": [ - true, - "check-branch", - "check-decl", - "check-module", - "check-operator", - "check-separator", - "check-type", - "check-typecast" - ] - } + "extends": ["tslint-react", "tslint-create-react-app-typescript"] } From 5a8b4ae8a09c38f706c30cdbcd7848424fbb0ef3 Mon Sep 17 00:00:00 2001 From: Tim Jacobi Date: Thu, 20 Jul 2017 11:43:04 +0100 Subject: [PATCH 5/5] add new package as dependency --- packages/react-scripts/package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/react-scripts/package.json b/packages/react-scripts/package.json index aceb4f65c..a0c37fabe 100644 --- a/packages/react-scripts/package.json +++ b/packages/react-scripts/package.json @@ -44,6 +44,7 @@ "ts-jest": "^20.0.7", "ts-loader": "^2.2.1", "tslint": "^5.2.0", + "tslint-create-react-app-typescript": "^1.0.0", "tslint-loader": "^3.5.3", "tslint-react": "^3.0.0", "typescript": "~2.4.0",