feat: only build one binary for all node versions (#50)

Author: giladgd

.github/workflows/build.yml

@@ -149,7 +149,7 @@ jobs:
           function getArches() {
             switch (process.env.ARTIFACT_NAME) {
               case "win":
-                return ["x64"];
+                return ["x64" /*, "arm64" */ ]; // disabled arm64 for now as compilation doesn't work
               case "linux":
                 return ["x64", "arm64", "armv7l", "ppc64le"];
               case "mac":
@@ -159,32 +159,32 @@ jobs:
             return ["x64"];
           }
           
-          const {versions: latestNodeVersions, latestVersion: latestNodeVersion} = await getLatestNodeVersions(Date.now() - 1000 * 60 * 60 * 24 * 14);
+          const {versions: latestNodeVersions} = await getLatestNodeVersions(Date.now() - 1000 * 60 * 60 * 24 * 14);
           
-          const minNodeVersion = latestNodeVersion - 4;
-          
-          const nodeVersions = [...latestNodeVersions].reduce((acc, [majorVersion, version]) => {
-            if (majorVersion >= minNodeVersion)
-              acc.push(version);
-            
-            return acc;
-          }, []);
+          const nodeVersion = latestNodeVersions.get(18);
+          const windowsOnArmNodeVersion = latestNodeVersions.get(20);
           const arches = getArches();
           
-          console.log("Building for node versions", nodeVersions, "and archs", arches);
+          if (nodeVersion == null || windowsOnArmNodeVersion == null) {
+            throw new Error("Could not find node versions");
+          }
+          
+          console.log("Building for node version", nodeVersion, "and archs", arches);
           
           await $`mkdir -p llamaBins`;
           
-          for (const nodeVersion of nodeVersions) {
-            for (const arch of arches) {
-              console.log(`Building ${arch} for node ${nodeVersion}`);
-              
-              const majorNodeVersion = parseInt(nodeVersion.slice("v".length))
-              
-              const binName = `${process.env.ARTIFACT_NAME}-${arch}-${majorNodeVersion}`; 
-              await $`node ./dist/cli/cli.js build --arch ${arch} --nodeTarget ${nodeVersion}`;
-              await $`mv ./llama/build/Release ${"./llamaBins/" + binName}`;
+          for (const arch of arches) {
+            let buildNodeVersion = nodeVersion;
+            
+            if (process.env.ARTIFACT_NAME === "win" && arch === "arm64") {
+              buildNodeVersion = windowsOnArmNodeVersion;
             }
+            
+            console.log(`Building ${arch} for node ${buildNodeVersion}`);
+            
+            const binName = `${process.env.ARTIFACT_NAME}-${arch}`; 
+            await $`node ./dist/cli/cli.js build --arch ${arch} --nodeTarget ${buildNodeVersion}`;
+            await $`mv ./llama/build/Release ${"./llamaBins/" + binName}`;
           }
           
           await $`echo "Built binaries:"`;

src/utils/getBin.ts

@@ -14,20 +14,15 @@ import {getCompiledLlamaCppBinaryPath} from "./compileLLamaCpp.js";
 const require = createRequire(import.meta.url);
 
 export async function getPrebuildBinPath(): Promise<string | null> {
-    const majorNodeVersion = parseInt(process.version.slice("v".length));
-    const supportedVersions = [majorNodeVersion, majorNodeVersion - 1];
-
-    function createPath(platform: string, arch: string, nodeVersion: number) {
-        return path.join(llamaBinsDirectory, `${platform}-${arch}-${nodeVersion}/llama-addon.node`);
+    function createPath(platform: string, arch: string) {
+        return path.join(llamaBinsDirectory, `${platform}-${arch}/llama-addon.node`);
     }
 
-    async function resolvePath(platform: string, arch: string, nodeVersions: number[]) {
-        for (const nodeVersion of nodeVersions) {
-            const binPath = createPath(platform, arch, nodeVersion);
+    async function resolvePath(platform: string, arch: string) {
+        const binPath = createPath(platform, arch);
 
-            if (await fs.pathExists(binPath))
-                return binPath;
-        }
+        if (await fs.pathExists(binPath))
+            return binPath;
 
         return null;
     }
@@ -36,14 +31,14 @@ export async function getPrebuildBinPath(): Promise<string | null> {
         switch (process.platform) {
             case "win32":
             case "cygwin":
-                return resolvePath("win", process.arch, supportedVersions);
+                return resolvePath("win", process.arch);
 
             case "linux":
             case "android":
-                return resolvePath("linux", process.arch, supportedVersions);
+                return resolvePath("linux", process.arch);
 
             case "darwin":
-                return resolvePath("mac", process.arch, supportedVersions);
+                return resolvePath("mac", process.arch);
         }
 
         return null;