Fix: type-annotations are marked as used (fixes bradzacher#61)

Author: weirdpattern

lib/rules/no-unused-vars.js

@@ -125,10 +125,80 @@ module.exports = {
             });
         }
 
+        /**
+         * Checks if the given node has a type annotation and marks it as used.
+         * @param {ASTNode} node the relevant AST node.
+         * @returns {void}
+         * @private
+         */
+        function markTypeAnnotationAsUsed(node) {
+            const annotation = node.typeAnnotation || node;
+
+            switch (annotation.type) {
+                case "TSTypeReference": {
+                    if (annotation.typeName.type === "TSArrayType") {
+                        markTypeAnnotationAsUsed(
+                            annotation.typeName.elementType
+                        );
+                    } else {
+                        markVariableAsUsed(context, annotation.typeName.name);
+                        if (
+                            annotation.typeParameters &&
+                            annotation.typeParameters.params
+                        ) {
+                            annotation.typeParameters.params.forEach(param => {
+                                markTypeAnnotationAsUsed(param);
+                            });
+                        }
+                    }
+
+                    break;
+                }
+                case "TSUnionType":
+                case "TSIntersectionType":
+                    annotation.types.forEach(type => {
+                        markTypeAnnotationAsUsed(type);
+                    });
+
+                    break;
+
+                default:
+                    break;
+            }
+        }
+
+        /**
+         * Checks if the given node has a return type and marks it as used.
+         * @param {ASTNode} node the relevant AST node.
+         * @returns {void}
+         * @private
+         */
+        function markFunctionReturnTypeAsUsed(node) {
+            if (node.returnType) {
+                markTypeAnnotationAsUsed(node.returnType);
+            }
+        }
+
         //----------------------------------------------------------------------
         // Public
         //----------------------------------------------------------------------
         return {
+            Identifier(node) {
+                if (node.typeAnnotation) {
+                    markTypeAnnotationAsUsed(node.typeAnnotation);
+                }
+            },
+
+            TypeAnnotation(node) {
+                if (node.typeAnnotation) {
+                    markTypeAnnotationAsUsed(node.typeAnnotation);
+                }
+            },
+
+            FunctionDeclaration: markFunctionReturnTypeAsUsed,
+            FunctionExpression: markFunctionReturnTypeAsUsed,
+            ArrowFunctionExpression: markFunctionReturnTypeAsUsed,
+
             ClassProperty: markDecoratorsAsUsed,
             ClassDeclaration(node) {
                 markDecoratorsAsUsed(node);

tests/lib/rules/no-unused-vars.js

@@ -175,6 +175,98 @@ ruleTester.run("no-unused-vars", ruleNoUnusedVars, {
                 "new Thing()"
             ].join("\n"),
             parser
+        },
+        {
+            code: [
+                "interface Base {}",
+                "const a: Base = {}",
+                "console.log(a);"
+            ].join("\n"),
+            parser
+        },
+        {
+            code: [
+                "import { Nullable } from 'nullable'",
+                "const a: Nullable<string> = 'hello'",
+                "console.log(a)"
+            ].join("\n"),
+            parser
+        },
+        {
+            code: [
+                "import { Nullable } from 'nullable'",
+                "import { SomeOther } from 'other'",
+                "const a: Nullable<SomeOther> = 'hello'",
+                "console.log(a)"
+            ].join("\n"),
+            parser
+        },
+        {
+            code: [
+                "import { Nullable } from 'nullable'",
+                "const a: Nullable | undefined = 'hello'",
+                "console.log(a)"
+            ].join("\n"),
+            parser
+        },
+        {
+            code: [
+                "import { Nullable } from 'nullable'",
+                "const a: Nullable & undefined = 'hello'",
+                "console.log(a)"
+            ].join("\n"),
+            parser
+        },
+        {
+            code: [
+                "import { Nullable } from 'nullable'",
+                "import { SomeOther } from 'other'",
+                "const a: Nullable<SomeOther[]> = 'hello'",
+                "console.log(a)"
+            ].join("\n"),
+            parser
+        },
+        {
+            code: [
+                "import { Nullable } from 'nullable'",
+                "import { SomeOther } from 'other'",
+                "const a: Nullable<Array<SomeOther>> = 'hello'",
+                "console.log(a)"
+            ].join("\n"),
+            parser
+        },
+        {
+            code: [
+                "import { Nullable } from 'nullable'",
+                "const a: Array<Nullable> = 'hello'",
+                "console.log(a)"
+            ].join("\n"),
+            parser
+        },
+        {
+            code: [
+                "import { Nullable } from 'nullable'",
+                "const a: Array<Nullable[]> = 'hello'",
+                "console.log(a)"
+            ].join("\n"),
+            parser
+        },
+        {
+            code: [
+                "import { Nullable } from 'nullable'",
+                "const a: Array<Array<Nullable>> = 'hello'",
+                "console.log(a)"
+            ].join("\n"),
+            parser
+        },
+        {
+            code: [
+                "import { Nullable } from 'nullable'",
+                "import { SomeOther } from 'other'",
+                "const a: Array<Nullable<SomeOther>> = 'hello'",
+                "console.log(a)"
+            ].join("\n"),
+            parser
         }
     ],
 
@@ -193,6 +285,37 @@ ruleTester.run("no-unused-vars", ruleNoUnusedVars, {
                     column: 10
                 }
             ]
+        },
+        {
+            code: [
+                "import { Nullable } from 'nullable';",
+                "const a: string = 'hello';",
+                "console.log(a);"
+            ].join("\n"),
+            parser,
+            errors: [
+                {
+                    message: "'Nullable' is defined but never used.",
+                    line: 1,
+                    column: 10
+                }
+            ]
+        },
+        {
+            code: [
+                "import { Nullable } from 'nullable';",
+                "import { SomeOther } from 'other';",
+                "const a: Nullable<string> = 'hello';",
+                "console.log(a);"
+            ].join("\n"),
+            parser,
+            errors: [
+                {
+                    message: "'SomeOther' is defined but never used.",
+                    line: 2,
+                    column: 10
+                }
+            ]
         }
     ]
 });