Skip to content

Commit 86c3a1e

Browse files
authored
Send message stream (#89)
* add sendFileStream rpc call * add sendFileStream into puppet server impl * add readme * 0.18.1 * change filebox to data with bytes type * add name attribute into stream request and response
1 parent d878252 commit 86c3a1e

File tree

5 files changed

+21
-1
lines changed

5 files changed

+21
-1
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,7 @@ TCP hole punching
223223

224224
### v0.18 (Oct 15, 2020)
225225
- Add new `MessageFileStream` and `MessageImageStream` to replace the `MessageFile` and `MessageImage` method to avoid blocking nodejs event loop when sending large files ([#88](https://github.com/Chatie/grpc/pull/88)) by [@windmemory](https://github.com/windmemory)
226+
- Add new `MessageSendFileStream` to replace the `MessageSendFile` method to avoid blocking nodejs event loop when sending large files ([#89](https://github.com/Chatie/grpc/pull/89)) by [@windmemory](https://github.com/windmemory)
226227

227228
### v0.17 (Aug 5, 2020)
228229

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@chatie/grpc",
3-
"version": "0.18.0",
3+
"version": "0.18.1",
44
"description": "gRPC for Chatie",
55
"main": "dist/src/index.js",
66
"typings": "dist/src/index.d.js",

proto/wechaty/puppet.proto

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,9 @@ service Puppet {
102102
rpc MessageUrl (puppet.MessageUrlRequest) returns (puppet.MessageUrlResponse) {}
103103

104104
rpc MessageSendContact (puppet.MessageSendContactRequest) returns (puppet.MessageSendContactResponse) {}
105+
// @deprecated: using MesageSendFileStream to transfer file message to server
105106
rpc MessageSendFile (puppet.MessageSendFileRequest) returns (puppet.MessageSendFileResponse) {}
107+
rpc MessageSendFileStream (stream puppet.MessageSendFileStreamRequest) returns (puppet.MessageSendFileStreamResponse) {}
106108
rpc MessageSendText (puppet.MessageSendTextRequest) returns (puppet.MessageSendTextResponse) {}
107109
rpc MessageSendMiniProgram (puppet.MessageSendMiniProgramRequest) returns (puppet.MessageSendMiniProgramResponse) {}
108110
rpc MessageSendUrl (puppet.MessageSendUrlRequest) returns (puppet.MessageSendUrlResponse) {}

proto/wechaty/puppet/message.proto

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ message MessageImageStreamRequest {
6262
}
6363
message MessageImageStreamResponse {
6464
bytes data = 1;
65+
string name = 2;
6566
}
6667

6768
message MessageContactRequest {
@@ -83,6 +84,7 @@ message MessageFileStreamRequest {
8384
}
8485
message MessageFileStreamResponse {
8586
bytes data = 1;
87+
string name = 2;
8688
}
8789

8890
message MessageMiniProgramRequest {
@@ -116,6 +118,15 @@ message MessageSendFileResponse {
116118
google.protobuf.StringValue id = 1;
117119
}
118120

121+
message MessageSendFileStreamRequest {
122+
string conversation_id = 1;
123+
bytes data = 2;
124+
string name = 3;
125+
}
126+
message MessageSendFileStreamResponse {
127+
google.protobuf.StringValue id = 1;
128+
}
129+
119130
message MessageSendTextRequest {
120131
string conversation_id = 1;
121132
string text = 2;

tests/puppet-server-impl.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,12 @@ export const puppetServerImpl: IPuppetServer = {
179179
throw new Error('not implemented.')
180180
},
181181

182+
messageSendFileStream: (call, callback) => {
183+
void call
184+
void callback
185+
throw new Error('not implemented.')
186+
},
187+
182188
messageSendMiniProgram: (call, callback) => {
183189
void call
184190
void callback

0 commit comments

Comments
 (0)