Skip to content

Wrong devtool type at Production>Source Mapping guide #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2017

Conversation

diegofaria
Copy link
Contributor

Problem

At the Production - Source Mapping guide, there's a suggestion to use a devtool style not supposed for production use, as the Devtool guide explains.

Solution

Suggest a devtool style suited for production, based on the Devtool guide.

@skipjack
Copy link
Collaborator

skipjack commented Sep 2, 2017

Good catch, @sokra does source-map look like a good recommendation to you?

Copy link
Collaborator

@skipjack skipjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to wait, we can always switch this later on if there's a different recommendation.

@skipjack skipjack merged commit 2ae1a53 into webpack:master Sep 3, 2017
@diegofaria diegofaria deleted the patch-1 branch September 4, 2017 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants