Skip to content

Document webpack change: Freeze hooks to prevent deopts #2411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
webpack-bot opened this issue Jul 30, 2018 · 0 comments · Fixed by #7160
Closed

Document webpack change: Freeze hooks to prevent deopts #2411

webpack-bot opened this issue Jul 30, 2018 · 0 comments · Fixed by #7160
Assignees
@snitin315
Labels
webpack5 Docs for webpack 5
Milestone
webpack 5

Comments

@webpack-bot
Copy link

A pull request by @ooflorent was merged and maintainers requested a documentation change.

See pull request: webpack/webpack#7813

Note: there is no speed penalty introduced by Object.freeze

This PR is a follow up of:

  • #7672
  • #7672

What kind of change does this PR introduce?

refactoring

Did you add tests for your changes?

no

Does this PR introduce a breaking change?

yes

What needs to be documented once your changes are merged?

hooks are no longer extensible. Use a WeakMap to add custom hooks.
@sokra sokra added this to the webpack 5 milestone Jul 30, 2018
@sokra sokra added webpack5 Docs for webpack 5 and removed webpack5 Docs for webpack 5 labels Dec 12, 2018
@anikethsaha anikethsaha mentioned this issue Feb 12, 2020
Closed
@snitin315 snitin315 self-assigned this Feb 24, 2024
@snitin315 snitin315 mentioned this issue Feb 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snitin315 snitin315

Labels
webpack5 Docs for webpack 5
Projects
None yet
Milestone
webpack 5
3 participants
@sokra @webpack-bot @snitin315