Skip to content

Commit ad8df9b

Browse files
sudarsangpmontogeek
authored andcommitted
docs(guides): Change var to let and move lodash under dependencies (#2409)
* docs(guides): change var to let * docs(guides): move lodash under dependencies * docs(guides): change var to let all occurrences * docs(guides): remove comment based on code review
1 parent 1ba9094 commit ad8df9b

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/content/guides/getting-started.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ __src/index.js__
5353

5454
``` javascript
5555
function component() {
56-
var element = document.createElement('div');
56+
let element = document.createElement('div');
5757

5858
// Lodash, currently included via a script, is required for this line to work
5959
element.innerHTML = _.join(['Hello', 'webpack'], ' ');
@@ -148,10 +148,9 @@ __src/index.js__
148148
+ import _ from 'lodash';
149149
+
150150
function component() {
151-
var element = document.createElement('div');
151+
let element = document.createElement('div');
152152

153153
- // Lodash, currently included via a script, is required for this line to work
154-
+ // Lodash, now imported by this script
155154
element.innerHTML = _.join(['Hello', 'webpack'], ' ');
156155

157156
return element;
@@ -291,7 +290,9 @@ __package.json__
291290
"license": "ISC",
292291
"devDependencies": {
293292
"webpack": "^4.0.1",
294-
"webpack-cli": "^2.0.9",
293+
"webpack-cli": "^2.0.9"
294+
},
295+
"dependencies": {
295296
"lodash": "^4.17.5"
296297
}
297298
}

0 commit comments

Comments
 (0)