add --progress cli test #1182
add --progress cli test #1182
Conversation
ryanwholey
force-pushed
the
add-a-cli-test
branch
from
3e4d415 to
55afe70
Compare
Codecov Report
@@ Coverage Diff @@
## master #1182 +/- ##
=======================================
Coverage 76.31% 76.31%
=======================================
Files 5 5
Lines 477 477
Branches 154 154
=======================================
Hits 364 364
Misses 113 113Continue to review full report at Codecov.
|
|
@ryanwholey thanks for the PR! we love getting new tests submitted and normally would be quick to add them to the repo. right now we're in a holding pattern on new code and new features while we prep v3 on the beta branch. The testing patterns have changed there as well. And while we're not looking for outside contributions on that branch at the moment, we will be in the near future. we're going to have to put this PR on hold for a bit, but we'll be circling back to it. And just a bit of a side note; when you have related code you want to add to an existing PR, all you need to do is make additional commits to the fork you submitted the PR from, and they'll show up automagically. |
|
thanks for taking a look! looking forward to the new release |
This pr adds a cli test for the --progress command line option
What kind of change does this PR introduce?
This is a dev change, it should increase test coverage but that's it
Did you add or update the
examples/?n/a
Summary
I put a pr up for allowing the dev server to be able to read the progress option from a passed webpack config and I noticed that there could probably be some more testing! I saw a nice comment on issue 623 outlining some nice cli tests so I thought I'd have a go at it.
Related issues:
1155 and
623
Does this PR introduce a breaking change?
no breaking changes here!
Other information