fix: use location.port as sock.port by default (#2850)

Author: ylemkimon

lib/utils/DevServerPlugin.js

@@ -28,15 +28,8 @@ class DevServerPlugin {
   apply(compiler) {
     const { options } = this;
 
-    // we're stubbing the app in this method as it's static and doesn't require
-    // a server to be supplied. createDomain requires an app with the
-    // address() signature.
     /** @type {string} */
-    const domain = createDomain(options, {
-      address() {
-        return { port: options.port };
-      },
-    });
+    const domain = createDomain(options);
     /** @type {string} */
     const host =
       options.client && options.client.host

test/e2e/ClientOptions.test.js

@@ -70,7 +70,7 @@ describe('sockjs client proxy', () => {
             page.waitFor(beforeBrowserCloseDelay).then(() => {
               browser.close().then(() => {
                 expect(requestObj.url()).toContain(
-                  `http://localhost:${port1}/ws`
+                  `http://localhost:${port2}/ws`
                 );
                 done();
               });

test/server/__snapshots__/Server.test.js.snap

@@ -6,7 +6,7 @@ Array [
     "client",
     "default",
     "index.js?http:",
-    "localhost:8100",
+    "localhost",
   ],
   Array [
     "node_modules",
@@ -26,7 +26,7 @@ Array [
     "client",
     "default",
     "index.js?http:",
-    "localhost:8100",
+    "localhost",
   ],
   Array [
     "node_modules",