refactor: resolve TODOs

Author: ylemkimon

bin/cli-flags.js

@@ -102,7 +102,6 @@ module.exports = {
       describe: 'Enable gzip compression',
       group: RESPONSE_GROUP,
     },
-    // findPort is currently not set up
     {
       name: 'port',
       type: Number,

test/client/utils/__snapshots__/createSocketUrl.test.js.snap

@@ -2,6 +2,8 @@
 
 exports[`createSocketUrl should return the url when __resourceQuery is ?test 1`] = `"/ws"`;
 
+exports[`createSocketUrl should return the url when __resourceQuery is file://filename 1`] = `"file://filename/ws"`;
+
 exports[`createSocketUrl should return the url when __resourceQuery is http://0.0.0.0 1`] = `"http://localhost/ws"`;
 
 exports[`createSocketUrl should return the url when __resourceQuery is http://127.0.0.1 1`] = `"http://127.0.0.1/ws"`;
@@ -22,6 +24,8 @@ exports[`createSocketUrl should return the url when __resourceQuery is undefined
 
 exports[`createSocketUrl should return the url when the current script source is ?test 1`] = `"/ws"`;
 
+exports[`createSocketUrl should return the url when the current script source is file://filename 1`] = `"file://filename/ws"`;
+
 exports[`createSocketUrl should return the url when the current script source is http://0.0.0.0 1`] = `"http://localhost/ws"`;
 
 exports[`createSocketUrl should return the url when the current script source is http://127.0.0.1 1`] = `"http://127.0.0.1/ws"`;

test/client/utils/createSocketUrl.test.js

@@ -11,9 +11,7 @@ describe('createSocketUrl', () => {
     'https://localhost:123',
     'http://user:pass@[::]:8080',
     'http://127.0.0.1',
-    // TODO: comment out after the major release
-    // https://github.com/webpack/webpack-dev-server/pull/1954#issuecomment-498043376
-    // 'file://filename',
+    'file://filename',
     // eslint-disable-next-line no-undefined
     undefined,
   ];