Skip to content

does not find loader-runner when using Yarn PnP #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DanielRuf opened this issue Sep 27, 2018 · 6 comments
Closed

does not find loader-runner when using Yarn PnP #32

DanielRuf opened this issue Sep 27, 2018 · 6 comments

Comments

@DanielRuf
Copy link

Error: Cannot find module 'loader-runner'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:581:15)
    at Function.Module._load (internal/modules/cjs/loader.js:507:25)
    at Module.require (internal/modules/cjs/loader.js:637:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/Users/druf/Library/Caches/Yarn/v3/npm-thread-loader-1.2.0-35dedb23cf294afbbce6c45c1339b950ed17e7a4/node_modules/thread-loader/dist/worker.js:11:21)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
internal/modules/cjs/loader.js:583
    throw err;
    ^
@michael-ciniawsky
Copy link
Member

Did you add https://github.com/arcanis/pnp-webpack-plugin to your config?

@DanielRuf
Copy link
Author

Did you add arcanis/pnp-webpack-plugin to your config?

Was this referenced / mentioned somewhere?
Might be better to have PnP support in thread-loader and webpack in general.

@DanielRuf
Copy link
Author

DanielRuf commented Sep 27, 2018

This does not help here as it seems. See Coding-Coach/coding-coach#84 and also facebook/create-react-app#5117

@arcanis
Copy link

arcanis commented Sep 27, 2018

Can you make a quick repro PR on the pnp-sample-app repository? I'll give it a look and can tell you what's breaking, and once it's fixed we can merge the PR as an example 🙂

@arcanis
Copy link

arcanis commented Sep 27, 2018

As for the PnP Webpack plugin, it's currently needed as enhanced-resolve doesn't yet have out-of-the-box support for PnP.

@DanielRuf
Copy link
Author

Can you make a quick repro PR on the pnp-sample-app repository? I'll give it a look and can tell you what's breaking, and once it's fixed we can merge the PR as an example 🙂

I'll check it this week and see if I can provide a PR to reproduce it in the playground repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants