fix(plugin-meetings): small refactor of code handling Locus API responses #4508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES #SPARK-697765
This pull request addresses
Code is not always going through the same functions when handling Locus API responses
by making the following changes
This is part of the webinar 5k work. It is a bit of refactoring that's needed for the rest of the webinar 5k work.
Changes done:
This refactor is needed for webinar 5k work, because when we use Locus hash trees, the API responses contain a body that doesn't have the
locusfield but instead containsdatasetsand a set of hash tree objects, so it's important that all code handling any API responses from Locus goes always through the same util functions and that the whole response (not just thelocuspart) reaches LocusInfo class.Change Type
The following scenarios where tested
unit tests, end-2-end manual testing as part of webinar 5k work with all the other changes in draft PR#4427
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.