scaffolding for typescript (reduxjs#3504)

* scaffolding for typescript

* add jest types so tests will compile

* remove rollup-plugin-typescript2, probably don't need it

* add missing eslint-import

* fix linting errors


Former-commit-id: 80cb6b8

Author: cellog

.babelrc.js

@@ -2,6 +2,7 @@ const { NODE_ENV } = process.env
 
 module.exports = {
   presets: [
+    '@babel/typescript',
     [
       '@babel/env',
       {

.eslintignore

@@ -3,3 +3,5 @@
 **/server.js
 **/webpack.config*.js
 **/flow-typed/**
+# TODO: figure out a way to lint this using flow instead of typescript
+examples/todos-flow

.eslintrc.js

@@ -1,22 +1,43 @@
 module.exports = {
   extends: 'react-app',
 
+  parser: '@typescript-eslint/parser',
+
+  plugins: ['@typescript-eslint'],
+
   settings: {
     react: {
       version: '16.8'
+    },
+    'import/parsers': {
+      '@typescript-eslint/parser': ['.ts', '.tsx']
+    },
+    'import/resolver': {
+      // use <root>/tsconfig.json
+      typescript: {}
     }
   },
 
   rules: {
-    'jsx-a11y/href-no-hash': 'off'
+    'jsx-a11y/href-no-hash': 'off',
+    'no-unused-vars': 'off',
+    '@typescript-eslint/no-unused-vars': [
+      'error',
+      {
+        vars: 'all',
+        args: 'after-used',
+        ignoreRestSiblings: true,
+        argsIgnorePattern: '^_' // ignore unused variables whose name is '_'
+      }
+    ]
   },
 
   overrides: [
     {
       files: 'test/**/*.js',
       env: {
-        jest: true,
-      },
-    },
-  ],
+        jest: true
+      }
+    }
+  ]
 }

examples/todomvc/src/components/App.spec.js

@@ -4,8 +4,7 @@ import App from './App'
 import Header from '../containers/Header'
 import MainSection from '../containers/MainSection'
 
-
-const setup = propOverrides => {
+const setup = _propOverrides => {
   const renderer = createRenderer()
   renderer.render(<App />)
   const output = renderer.getRenderOutput()
@@ -16,16 +15,16 @@ describe('components', () => {
   describe('Header', () => {
     it('should render', () => {
       const output = setup()
-      const [ header ] = output.props.children
+      const [header] = output.props.children
       expect(header.type).toBe(Header)
     })
   })
-  
+
   describe('Mainsection', () => {
     it('should render', () => {
       const output = setup()
-      const [ , mainSection ] = output.props.children
+      const [, mainSection] = output.props.children
       expect(mainSection.type).toBe(MainSection)
     })
   })
-})
+})

package-lock.json.REMOVED.git-id

@@ -44,7 +44,8 @@
     "test:watch": "npm test -- --watch",
     "test:cov": "npm test -- --coverage",
     "build": "rollup -c",
-    "prepare": "npm run clean && npm run format:check && npm run lint && npm test",
+    "prepare": "npm run clean && npm run check-types && npm run format:check && npm run lint && npm test",
+    "check-types": "tsc",
     "examples:lint": "eslint examples",
     "examples:test": "cross-env CI=true babel-node examples/testAll.js"
   },
@@ -60,15 +61,18 @@
     "@babel/plugin-proposal-object-rest-spread": "^7.5.4",
     "@babel/preset-env": "^7.5.4",
     "@babel/preset-flow": "^7.0.0",
+    "@babel/preset-typescript": "^7.3.3",
     "@babel/register": "^7.4.4",
-    "@typescript-eslint/eslint-plugin": "^1.11.0",
-    "@typescript-eslint/parser": "^1.11.0",
+    "@types/jest": "^24.0.17",
+    "@typescript-eslint/eslint-plugin": "^1.13.0",
+    "@typescript-eslint/parser": "^1.13.0",
     "babel-core": "^7.0.0-bridge.0",
     "babel-eslint": "^10.0.2",
     "babel-jest": "^24.8.0",
     "cross-env": "^5.2.0",
     "eslint": "^5.16.0",
     "eslint-config-react-app": "^4.0.1",
+    "eslint-import-resolver-typescript": "^1.1.1",
     "eslint-plugin-flowtype": "^2.50.3",
     "eslint-plugin-import": "^2.18.0",
     "eslint-plugin-jsx-a11y": "^6.2.3",

package.json

@@ -1,3 +1,4 @@
+import { DEFAULT_EXTENSIONS } from '@babel/core'
 import nodeResolve from 'rollup-plugin-node-resolve'
 import babel from 'rollup-plugin-babel'
 import replace from 'rollup-plugin-replace'
@@ -14,7 +15,11 @@ export default [
       ...Object.keys(pkg.dependencies || {}),
       ...Object.keys(pkg.peerDependencies || {})
     ],
-    plugins: [babel()]
+    plugins: [
+      babel({
+        extensions: [...DEFAULT_EXTENSIONS, '.ts']
+      })
+    ]
   },
 
   // ES
@@ -25,7 +30,11 @@ export default [
       ...Object.keys(pkg.dependencies || {}),
       ...Object.keys(pkg.peerDependencies || {})
     ],
-    plugins: [babel()]
+    plugins: [
+      babel({
+        extensions: [...DEFAULT_EXTENSIONS, '.ts']
+      })
+    ]
   },
 
   // ES for Browsers
@@ -37,6 +46,10 @@ export default [
       replace({
         'process.env.NODE_ENV': JSON.stringify('production')
       }),
+      babel({
+        extensions: [...DEFAULT_EXTENSIONS, '.ts'],
+        exclude: 'node_modules/**'
+      }),
       terser({
         compress: {
           pure_getters: true,
@@ -60,6 +73,7 @@ export default [
     plugins: [
       nodeResolve(),
       babel({
+        extensions: [...DEFAULT_EXTENSIONS, '.ts'],
         exclude: 'node_modules/**'
       }),
       replace({
@@ -80,6 +94,7 @@ export default [
     plugins: [
       nodeResolve(),
       babel({
+        extensions: [...DEFAULT_EXTENSIONS, '.ts'],
         exclude: 'node_modules/**'
       }),
       replace({

rollup.config.js

@@ -120,7 +120,7 @@ describe('applyMiddleware', () => {
     }
 
     function dummyMiddleware({ dispatch }) {
-      return next => action => dispatch(action, testCallArgs)
+      return _next => action => dispatch(action, testCallArgs)
     }
 
     const store = createStore(

test/applyMiddleware.spec.js

@@ -1 +1 @@
-6a837c0d1d9dcadcfbc483465a928cac701ff99d
+f3700e2d6d86c13c2302d46af03dbf9bfac16f4e

test/createStore.spec.js.REMOVED.git-id

@@ -0,0 +1 @@
+052d09d209c201be4d4cdbc8fcdf634b5172ab8c