From fe27bceb75f34795d866d39b54b69993da7470c1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philip=20J=C3=A4genstedt?= <philip@foolip.org>
Date: Thu, 18 Apr 2024 09:48:29 +0200
Subject: [PATCH] Remove unused code for ignoring removed files

This code was added in commit a83df6294d8d95920480a9f2ed44e124d4a460d5
but became unused again in commit 23367466a566f9ce113bedba2ffa24dc8378881c.
Since then it's been tested, but still not used.

There's only one require('./filenames') in the code base, so changing
the return value of that module is safe.
---
 lib/metadata/filenames.js |  5 +----
 lib/metadata/index.js     |  4 +---
 test/get-metadata.js      | 19 -------------------
 3 files changed, 2 insertions(+), 26 deletions(-)

diff --git a/lib/metadata/filenames.js b/lib/metadata/filenames.js
index 7bc0819..871927c 100644
--- a/lib/metadata/filenames.js
+++ b/lib/metadata/filenames.js
@@ -4,9 +4,6 @@ var github = require('../github'),
 
 module.exports = async function(issue) {
     const files = await github.get("/repos/:owner/:repo/pulls/:number/files", { number: issue });
-    return {
-        all: files.map(funk.prop('filename')),
-        ignoreRemoved: files.filter((file) => file.status != 'removed').map(funk.prop('filename'))
-    };
+    return files.map(funk.prop('filename'));
 };
 
diff --git a/lib/metadata/index.js b/lib/metadata/index.js
index f1033e1..2a39a53 100644
--- a/lib/metadata/index.js
+++ b/lib/metadata/index.js
@@ -49,9 +49,7 @@ module.exports = async function getMetadata(number, author, title, content) {
     };
     author = author.toLowerCase();
 
-    const filenames = await getFilenames(number);
-    metadata.filenames = filenames.all;
-    metadata.filenamesIgnoreRemoved = filenames.ignoreRemoved;
+    metadata.filenames = await getFilenames(number);
     metadata.paths = paths(metadata.filenames);
     const fileLabels = labels.fromFiles(metadata.filenames);
     metadata.isRoot = metadata.filenames.some(function(path) {
diff --git a/test/get-metadata.js b/test/get-metadata.js
index 3fb403b..f0b9f80 100644
--- a/test/get-metadata.js
+++ b/test/get-metadata.js
@@ -56,7 +56,6 @@ suite('getMetadata', function() {
             ],
             rootReviewers: [ 'jgraham' ],
             filenames: [ 'WebIDL/interfaces.html', 'interfaces/WebIDL.idl' ],
-            filenamesIgnoreRemoved: [ 'WebIDL/interfaces.html', 'interfaces/WebIDL.idl' ],
             paths: [ 'WebIDL', 'interfaces' ],
             labels: [ 'WebIDL', 'interfaces', 'wg-webplatform' ],
             isRoot: false,
@@ -140,12 +139,6 @@ suite('getMetadata', function() {
             "svg/coordinate-systems/parsing/vector-effect-invalid.svg",
             "svg/coordinate-systems/parsing/vector-effect-valid.svg",
           ],
-          filenamesIgnoreRemoved: [
-            "svg/coordinate-systems/inheritance.svg",
-            "svg/coordinate-systems/parsing/vector-effect-computed.svg",
-            "svg/coordinate-systems/parsing/vector-effect-invalid.svg",
-            "svg/coordinate-systems/parsing/vector-effect-valid.svg",
-          ],
           isMergeable: true,
           isRoot: false,
           isWebKitVerified: false,
@@ -387,18 +380,6 @@ suite('getMetadata', function() {
                'media-source/webm/test-a-1s.webm-manifest.json',
                'media-source/webm/test-v-1s-blue.webm',
                'media-source/webm/test-v-1s-blue.webm-manifest.json' ],
-            filenamesIgnoreRemoved:
-             [ 'lint.whitelist',
-               'media-source/mediasource-video-is-visible-expected.html',
-               'media-source/mediasource-video-is-visible.html',
-               'media-source/mp4/test-a-1s.mp4',
-               'media-source/mp4/test-a-1s.mp4-manifest.json',
-               'media-source/mp4/test-v-1s-blue.mp4',
-               'media-source/mp4/test-v-1s-blue.mp4-manifest.json',
-               'media-source/webm/test-a-1s.webm',
-               'media-source/webm/test-a-1s.webm-manifest.json',
-               'media-source/webm/test-v-1s-blue.webm',
-               'media-source/webm/test-v-1s-blue.webm-manifest.json' ],
             paths: [ '', 'media-source', 'media-source/mp4', 'media-source/webm' ],
             isRoot: true,
             specs: