feat: update to dotnet 10, with unit test fixes and some packages updates #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you! This looks great. I will get this merged/released later today. |
WeihanLi
reviewed
Nov 26, 2025
| <PackageReference Include="Spectre.Console.Cli" Version="0.49.1" /> | ||
| <PackageReference Include="System.IO.Abstractions" Version="21.1.3" /> | ||
| <PackageReference Include="System.Configuration.ConfigurationManager" Version="9.0.0" /> | ||
| <PackageReference Include="Spectre.Console.Cli" Version="0.53.0" /> |
Contributor
There was a problem hiding this comment.
There's a hotfix version later this version
Suggested change
| <PackageReference Include="Spectre.Console.Cli" Version="0.53.0" /> | |
| <PackageReference Include="Spectre.Console.Cli" Version="0.53.1" /> |
WeihanLi
reviewed
Nov 26, 2025
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" /> | ||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" /> |
Contributor
There was a problem hiding this comment.
Suggested change
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" /> | |
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" /> |
WeihanLi
reviewed
Nov 26, 2025
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="PrettyPrompt" Version="4.1.1" /> | ||
| <PackageReference Include="System.CommandLine" Version="2.0.0-beta4.22272.1" /> |
Contributor
There was a problem hiding this comment.
Maybe could move to the stable version, but may need to handle some breaking changes
Suggested change
| <PackageReference Include="System.CommandLine" Version="2.0.0-beta4.22272.1" /> | |
| <PackageReference Include="System.CommandLine" Version="2.0.0" /> |
Author
There was a problem hiding this comment.
Yes, I was looking into that... Although I managed to run it, many tests broke and I started to look into them to see exactly what needed to be updated... Might take some time
Author
|
I will be out for the rest of the week, but I can look as soon as I get back, on why the build broke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the Contributing Guidelines:
Title
Update to .NET 10 and refresh dependencies
Description
Align the solution with .NET 10, refresh Roslyn/NuGet/test dependencies, and expand coverage for locating the .NET 10 runtime/reference packs.
Changes Made
1. Updated to .NET 10
Switched all projects and test assets to target net10.0
Added global.json to pin SDK 10 and keep roll-forward behavior
2. Updated NuGet packages
Bumped Roslyn, NuGet client packages, Spectre.Console, System.* libraries, and OpenAI to current net10-compatible versions
Updated test dependencies (xUnit, coverlet, Spectre.Console.Testing, System.IO.Abstractions.TestingHelpers)
Added net10 runtime locator tests for global installs and NuGet fallbacks; updated evaluation/source-link expectations
Why These Changes?
.NET 10: Keep the project current with the latest SDK/runtime and