Skip to content

Example of the credentialSchema.id resolution to schema #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
troyronda opened this issue Dec 12, 2019 · 6 comments · Fixed by #187
Closed

Example of the credentialSchema.id resolution to schema #19

troyronda opened this issue Dec 12, 2019 · 6 comments · Fixed by #187
Assignees
Labels

Comments

@troyronda
Copy link

troyronda commented Dec 12, 2019

As a followup to #9, it would also be helpful to briefly summarize how the schema document was fetched.

In Example 11, the following is shown:

"credentialSchema": {
    "id": "did:work:MDP8AsFhHzhwUvGNuYkX7T;id=06e126d1-fa44-4882-a243-1e326fbe21db;version=1.0",
    "type": "JsonSchemaValidator2018"
  },

It would also be helpful to the reader to see how
did:work:MDP8AsFhHzhwUvGNuYkX7T;id=06e126d1-fa44-4882-a243-1e326fbe21db;version=1.0
resolved to the schema in Example 10.

@troyronda
Copy link
Author

troyronda commented Dec 12, 2019

(I guess somewhat related to #17 (comment)).

@troyronda
Copy link
Author

Also, the link to "Generic DID Parameter Name" is broken in Terminology (https://w3c-ccg.github.io/vc-json-schemas/#terminology)

https://w3c-ccg.github.io/did-core/#generic-did-parameter-names => https://w3c.github.io/did-core/#generic-did-parameter-names

@decentralgabe
Copy link
Collaborator

Yes we need to work out a section on resolution. My understanding has been that the way you resolve a did document is also the way you resolve a schema. I think we will develop this understanding in #17.

I will fix the link thanks for pointing it out.

@decentralgabe decentralgabe self-assigned this Nov 9, 2022
@decentralgabe
Copy link
Collaborator

Consider adding a section on resolution https://www.w3.org/TR/did-core/#resolution, and consider resolutionMetadata

@andresuribe87
Copy link
Collaborator

The original example posted is outdated. The examples in VCDM under Data Schemas all have the id property set to a URL. So there is no update to do here in the examples.

Regarding adding a section on resolution, I don't think it's needed for vc-json-schema. The id property is already specified in VCDM.

I think this should be closed, unless @decentralgabe had something else in mind.

@decentralgabe
Copy link
Collaborator

I agree this should be closed, but there's currently an empty section on resolution that should be removed with this issue's closure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants