Skip to content

Fix(MdDatepicker): Propagate clear event #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dragosct merged 1 commit into from
May 27, 2020
Merged

Fix(MdDatepicker): Propagate clear event #1967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/components/MdDatepicker/MdDatepicker.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<md-field :class="['md-datepicker', { 'md-native': !this.mdOverrideNative }]" md-clearable>
<md-field :class="['md-datepicker', { 'md-native': !this.mdOverrideNative }]" :md-clearable="mdClearable" @md-clear="onClear">
Copy link
Contributor

@saxxi saxxi Jan 29, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about

<md-field
  :class="['md-datepicker', { 'md-native': !this.mdOverrideNative }]"
  v-bind="$props"
  v-on="listeners">

You can add a computed

    computed: {
      listeners () {
        return {
          ...this.$listeners,
          // here you can add override listeners
        }
      },
    },

Then let the caller decide to add a md-clearable:

<md-datepicker md-clearable ... >
  <label>Date</label>
</md-datepicker>

Copy link

@gierschv gierschv Apr 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for this solution!

Copy link
Collaborator

@oliver-ni oliver-ni May 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current way is fine, to stay consistent with the existing api

<md-date-icon class="md-date-icon" @click.native="toggleDialog" />
<md-input :type="type" ref="input" v-model="inputDate" @focus.native="onFocus" :pattern="pattern" />

Expand Down Expand Up @@ -65,6 +65,10 @@
MdDebounce: {
type: Number,
default: 1000
},
mdClearable: {
type: Boolean,
default: true
}
},
data: () => ({
Expand Down Expand Up @@ -221,6 +225,9 @@
} else {
Vue.util.warn(`The datepicker value is not a valid date. Given value: ${this.value}`)
}
},
onClear() {
this.$emit('md-clear')
}
},
created () {
Expand Down