From 42335ef57f1fb9083518a9cfd1ae0507834553f0 Mon Sep 17 00:00:00 2001 From: Haoqun Jiang Date: Sat, 7 Aug 2021 15:21:12 +0800 Subject: [PATCH] feat(unit-jest): add jest as a peer dependency Eventually we need to update to Jest 27 + vue2-jest / vue3-jest So let's make it a peer dependency to ease the pain of breaking changes. To not surprise existing beta users, jest 26 is still listed as a direct dependency in the next release. --- packages/@vue/cli-plugin-unit-jest/generator/index.js | 1 + packages/@vue/cli-plugin-unit-jest/migrator/index.js | 4 +++- packages/@vue/cli-plugin-unit-jest/package.json | 1 + 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/@vue/cli-plugin-unit-jest/generator/index.js b/packages/@vue/cli-plugin-unit-jest/generator/index.js index 7ed8754f34..6ae1a140a0 100644 --- a/packages/@vue/cli-plugin-unit-jest/generator/index.js +++ b/packages/@vue/cli-plugin-unit-jest/generator/index.js @@ -12,6 +12,7 @@ module.exports = (api, options, rootOptions, invoking) => { 'test:unit': 'vue-cli-service test:unit' }, devDependencies: { + 'jest': '^26.6.3', 'vue-jest': isVue3 ? '^5.0.0-0' : '^4.0.1', '@vue/test-utils': isVue3 ? '^2.0.0-0' : '^1.1.3' }, diff --git a/packages/@vue/cli-plugin-unit-jest/migrator/index.js b/packages/@vue/cli-plugin-unit-jest/migrator/index.js index 843b2cee53..1970d1a236 100644 --- a/packages/@vue/cli-plugin-unit-jest/migrator/index.js +++ b/packages/@vue/cli-plugin-unit-jest/migrator/index.js @@ -1,7 +1,9 @@ /** @param {import('@vue/cli/lib/MigratorAPI')} api MigratorAPI */ module.exports = (api) => { api.extendPackage(pkg => { - const newDevDeps = {} + const newDevDeps = { + 'jest': '^26.6.3' + } const allDeps = { ...pkg.dependencies, diff --git a/packages/@vue/cli-plugin-unit-jest/package.json b/packages/@vue/cli-plugin-unit-jest/package.json index 071869d572..08ccf64656 100644 --- a/packages/@vue/cli-plugin-unit-jest/package.json +++ b/packages/@vue/cli-plugin-unit-jest/package.json @@ -41,6 +41,7 @@ }, "peerDependencies": { "@vue/cli-service": "^3.0.0 || ^4.0.0 || ^5.0.0-0", + "jest": "^26.3.3", "ts-jest": "^26.5.3", "vue-jest": "^4.0.1 || ^5.0.0-0" },