chore: remove tslint specific code

Author: Christopher Quadflieg

packages/@vue/cli-plugin-e2e-cypress/__tests__/cypressPlugin.spec.js

@@ -30,7 +30,6 @@ test('should work with TS', async () => {
     plugins: {
       '@vue/cli-plugin-typescript': {
         'classComponent': true,
-        'tsLint': true,
         'lintOn': ['save']
       },
       '@vue/cli-plugin-e2e-cypress': {}

packages/@vue/cli-plugin-typescript/__tests__/tsConvertLintFlags.spec.js

@@ -81,12 +81,11 @@ test('use with router', async () => {
 })
 
 test('lint', async () => {
-  const { pkg, files } = await generateWithPlugin([
+  const { pkg } = await generateWithPlugin([
     {
       id: 'ts',
       apply: require('../generator'),
       options: {
-        tsLint: true,
         lintOn: ['save', 'commit']
       }
     }
@@ -99,8 +98,6 @@ test('lint', async () => {
     '*.ts': ['vue-cli-service lint', 'git add'],
     '*.vue': ['vue-cli-service lint', 'git add']
   })
-
-  expect(files['tslint.json']).toBeTruthy()
 })
 
 test('lint with no lintOnSave', async () => {
@@ -109,7 +106,6 @@ test('lint with no lintOnSave', async () => {
       id: 'ts',
       apply: require('../generator'),
       options: {
-        tsLint: true,
         lintOn: ['commit']
       }
     }

packages/@vue/cli-plugin-typescript/__tests__/tsGenerator.spec.js

@@ -1,7 +1,6 @@
-module.exports = (api, { tsLint = false, convertJsToTs = true } = {}) => {
+module.exports = (api, { convertJsToTs = true } = {}) => {
   const jsRE = /\.js$/
   const excludeRE = /^tests\/e2e\/|(\.config|rc)\.js$/
-  const convertLintFlags = require('../lib/convertLintFlags')
   api.postProcessFiles(files => {
     if (convertJsToTs) {
       // delete all js files that have a ts file of the same name
@@ -10,10 +9,7 @@ module.exports = (api, { tsLint = false, convertJsToTs = true } = {}) => {
         if (jsRE.test(file) && !excludeRE.test(file)) {
           const tsFile = file.replace(jsRE, '.ts')
           if (!files[tsFile]) {
-            let content = files[file]
-            if (tsLint) {
-              content = convertLintFlags(content)
-            }
+            const content = files[file]
             files[tsFile] = content
           }
           delete files[file]
@@ -22,10 +18,7 @@ module.exports = (api, { tsLint = false, convertJsToTs = true } = {}) => {
     } else {
       // rename only main file to main.ts
       const tsFile = api.entryFile.replace(jsRE, '.ts')
-      let content = files[api.entryFile]
-      if (tsLint) {
-        content = convertLintFlags(content)
-      }
+      const content = files[api.entryFile]
       files[tsFile] = content
       delete files[api.entryFile]
     }

packages/@vue/cli-plugin-typescript/__tests__/tsPluginTSLint.spec.js

@@ -1,6 +1,5 @@
 module.exports = (api, {
   classComponent,
-  tsLint,
   lintOn = [],
   convertJsToTs,
   allowJs
@@ -24,42 +23,6 @@ module.exports = (api, {
     })
   }
 
-  if (tsLint) {
-    api.extendPackage({
-      scripts: {
-        lint: 'vue-cli-service lint'
-      }
-    })
-
-    if (!lintOn.includes('save')) {
-      api.extendPackage({
-        vue: {
-          lintOnSave: false
-        }
-      })
-    }
-
-    if (lintOn.includes('commit')) {
-      api.extendPackage({
-        devDependencies: {
-          'lint-staged': '^9.5.0'
-        },
-        gitHooks: {
-          'pre-commit': 'lint-staged'
-        },
-        'lint-staged': {
-          '*.ts': ['vue-cli-service lint', 'git add'],
-          '*.vue': ['vue-cli-service lint', 'git add']
-        }
-      })
-    }
-
-    // lint and fix files on creation complete
-    api.onCreateComplete(() => {
-      return require('../lib/tslint')({}, api, true)
-    })
-  }
-
   // late invoke compat
   if (invoking) {
     if (api.hasPlugin('unit-mocha')) {
@@ -84,5 +47,5 @@ module.exports = (api, {
     hasJest: api.hasPlugin('unit-jest')
   })
 
-  require('./convert')(api, { tsLint, convertJsToTs })
+  require('./convert')(api, { convertJsToTs })
 }

packages/@vue/cli-plugin-typescript/generator/convert.js

@@ -2,9 +2,7 @@ import Vue, { VNode } from 'vue'
 
 declare global {
   namespace JSX {
-    // tslint:disable no-empty-interface
     interface Element extends VNode {}
-    // tslint:disable no-empty-interface
     interface ElementClass extends Vue {}
     interface IntrinsicElements {
       [elem: string]: any

packages/@vue/cli-plugin-typescript/generator/index.js

@@ -1,7 +1,6 @@
 const path = require('path')
 
 module.exports = (api, projectOptions) => {
-  const fs = require('fs')
   const useThreads = process.env.NODE_ENV === 'production' && !!projectOptions.parallel
 
   api.chainWebpack(config => {
@@ -83,26 +82,10 @@ module.exports = (api, projectOptions) => {
         .plugin('fork-ts-checker')
           .use(require('fork-ts-checker-webpack-plugin'), [{
             vue: true,
-            tslint: projectOptions.lintOnSave !== false && fs.existsSync(api.resolve('tslint.json')),
             formatter: 'codeframe',
             // https://github.com/TypeStrong/ts-loader#happypackmode-boolean-defaultfalse
             checkSyntacticErrors: useThreads
           }])
     }
   })
-
-  if (!api.hasPlugin('eslint')) {
-    api.registerCommand('lint', {
-      description: 'lint source files with TSLint',
-      usage: 'vue-cli-service lint [options] [...files]',
-      options: {
-        '--format [formatter]': 'specify formatter (default: codeFrame)',
-        '--no-fix': 'do not fix errors',
-        '--formatters-dir [dir]': 'formatter directory',
-        '--rules-dir [dir]': 'rules directory'
-      }
-    }, args => {
-      return require('./lib/tslint')(args, api)
-    })
-  }
 }