Skip to content

Commit 1f15a01

Browse files
committed
Fix weird race issues.
Always pass call callback function on generate. Previously tests were randomly failing when running few times in a row.
1 parent 90cb6a7 commit 1f15a01

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

test/e2e/test.js

+8-8
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@ const generate = require('../../lib/generate')
1212
const metadata = require('../../lib/options')
1313
const { isLocalPath, getTemplatePath } = require('../../lib/local-path')
1414

15-
const MOCK_META_JSON_PATH = './test/e2e/mock-meta-json'
16-
const MOCK_TEMPLATE_REPO_PATH = './test/e2e/mock-template-repo'
15+
const MOCK_META_JSON_PATH = path.resolve('./test/e2e/mock-meta-json')
16+
const MOCK_TEMPLATE_REPO_PATH = path.resolve('./test/e2e/mock-template-repo')
1717
const MOCK_TEMPLATE_BUILD_PATH = path.resolve('./test/e2e/mock-template-build')
18-
const MOCK_METADATA_REPO_JS_PATH = './test/e2e/mock-metadata-repo-js'
19-
const MOCK_SKIP_GLOB = './test/e2e/mock-skip-glob'
18+
const MOCK_METADATA_REPO_JS_PATH = path.resolve('./test/e2e/mock-metadata-repo-js')
19+
const MOCK_SKIP_GLOB = path.resolve('./test/e2e/mock-skip-glob')
2020

2121
function monkeyPatchInquirer (answers) {
2222
// monkey patch inquirer
@@ -68,16 +68,16 @@ describe('vue-cli', () => {
6868
})
6969
})
7070

71-
it('adds additional data to meta data', () => {
72-
const data = generate('test', MOCK_META_JSON_PATH, MOCK_TEMPLATE_BUILD_PATH)
71+
it('adds additional data to meta data', done => {
72+
const data = generate('test', MOCK_META_JSON_PATH, MOCK_TEMPLATE_BUILD_PATH, done)
7373
expect(data.destDirName).to.equal('test')
7474
expect(data.inPlace).to.equal(false)
7575
})
7676

77-
it('sets `inPlace` to true when generating in same directory', () => {
77+
it('sets `inPlace` to true when generating in same directory', done => {
7878
const currentDir = process.cwd()
7979
process.chdir(MOCK_TEMPLATE_BUILD_PATH)
80-
const data = generate('test', MOCK_META_JSON_PATH, MOCK_TEMPLATE_BUILD_PATH)
80+
const data = generate('test', MOCK_META_JSON_PATH, MOCK_TEMPLATE_BUILD_PATH, done)
8181
expect(data.destDirName).to.equal('test')
8282
expect(data.inPlace).to.equal(true)
8383
process.chdir(currentDir)

0 commit comments

Comments
 (0)