Skip to content

Commit 1e10161

Browse files
chrisvfritzAkryum
authored andcommitted
fix(cli-plugin-eslint): remove base rules from ui (#2029)
1 parent 7953d83 commit 1e10161

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

packages/@vue/cli-plugin-eslint/__tests__/ui.spec.js

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,17 +112,26 @@ describe('getEslintPrompts', () => {
112112
'dolor': {
113113
meta: {
114114
docs: {
115-
category: 'base',
115+
category: 'strongly-recommended',
116116
description: 'Dolor description',
117117
url: 'http://test.com/dolor'
118118
}
119119
}
120+
},
121+
'sit': {
122+
meta: {
123+
docs: {
124+
category: 'base',
125+
description: 'Sit description',
126+
url: 'http://test.com/sit'
127+
}
128+
}
120129
}
121130
}
122131

123132
const prompts = getEslintPrompts(data, rules)
124133

125-
it('creates an array with three settings', () => {
134+
it('creates an array with 3 settings, leaving out category "base"', () => {
126135
expect(prompts).toHaveLength(3)
127136
})
128137

@@ -147,7 +156,7 @@ describe('getEslintPrompts', () => {
147156
expect(prompts[2].choices).toHaveLength(4)
148157
})
149158

150-
it('sets a default value to "ERROR" for rule that belong to the choosen config', () => {
159+
it('sets a default value to "ERROR" for rule that belong to the chosen config', () => {
151160
expect(prompts[0].default).toBe('"error"')
152161
expect(prompts[1].default).toBe('"error"')
153162
expect(prompts[2].default).toBe('"off"')

packages/@vue/cli-plugin-eslint/ui/configDescriptor.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
const CONFIG = 'org.vue.eslintrc'
22

33
const CATEGORIES = [
4-
'base',
54
'essential',
65
'strongly-recommended',
76
'recommended',

packages/@vue/cli-ui/locales/en.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -584,7 +584,6 @@
584584
"essential": "Essential",
585585
"strongly-recommended": "Strongly recommended",
586586
"recommended": "Recommended",
587-
"use-with-caution": "Use with caution",
588587
"uncategorized": "Uncategorized"
589588
},
590589
"setting": {

0 commit comments

Comments
 (0)